Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic note embedding #362

Open
kukimik opened this issue Oct 23, 2022 · 0 comments
Open

Cyclic note embedding #362

kukimik opened this issue Oct 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kukimik
Copy link
Contributor

kukimik commented Oct 23, 2022

Describe the bug
Embedding notes may create cycles:

some_note.md:

blah

![[other_note]]

blah

other_note.md:

aaa

![[some_note]]

bbb

Screenshots
The result (in live preview) looks like this:
Peek 2022-10-11 22-10

Expected behavior
I think the cycle should be detected and the embedding should stop at this point, probably displaying some message in place of the non-embedded note.

Additional context
I was asked to open an issue in #24 (comment).

When this was first reported on 8 Nov 2021, I couldn't open any of the notes in browser (the page didn't load at all, it looked like it was waiting for some infinite loop to finish). Now I can do it. I don't know whether it's the result of some change in emanote itself, or me using another computer.

@kukimik kukimik added the bug Something isn't working label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant