Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes and embedding: duplicate HTML element ids #360

Open
kukimik opened this issue Oct 23, 2022 · 1 comment
Open

Footnotes and embedding: duplicate HTML element ids #360

kukimik opened this issue Oct 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@kukimik
Copy link
Contributor

kukimik commented Oct 23, 2022

A note that both

  • contains a footnote, and
  • embeds another note, which also contains a footnote

will have two elements with the same id attribute in the resulting HTML, which is an error.

This happens because the footnotes numbering scheme does not depend on the note:

https://github.com/EmaApps/emanote/blob/944767a86152af3aab884e7c2ce5382c94162f33/default/templates/components/pandoc.tpl#L60

I think this can be resolved for example by including in some form (maybe a hash?) the note's route in the footnote's id. The downside is that the ids will be ugly.

Another idea is to construct the ids in a different way only when the note is embedded.

@kukimik kukimik added the bug Something isn't working label Oct 23, 2022
@srid
Copy link
Owner

srid commented Nov 28, 2022

Related #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants