Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

NewCommitPreorderIter Fails with object not found When iterating over incomplete history. #1151

Open
NonLogicalDev opened this issue May 16, 2019 · 1 comment · Fixed by kwngo/fork.lib.go.go-git#1 · May be fixed by #1152

Comments

@NonLogicalDev
Copy link

NonLogicalDev commented May 16, 2019

In remote.go in getHaves, getHavesRef fails with object not found error when
iterating over incomplete history.

This causes Fetch to fail under certain circumstances, such as (at least) when fetching remotes with unrelated histories.

This likely happens because commits are processed in Preorder and once it reaches the last commit fetched with a given Depth, it fails for find its parent.

Suggestion Short Term

Ignore object not found error during a fetch operation

Suggestion Long Term

Add a terminal empty commit after fetch with a certain depth, to signify that no further commits can be reached. This will guarantee that object not found error if it happens, happens because of corrupt data as opposed to truncated history.

NonLogicalDev added a commit to NonLogicalDev/fork.lib.go.go-git that referenced this issue May 17, 2019
…ory. Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.
NonLogicalDev added a commit to NonLogicalDev/fork.lib.go.go-git that referenced this issue May 17, 2019
…Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.
NonLogicalDev added a commit to NonLogicalDev/fork.lib.go.go-git that referenced this issue May 17, 2019
…Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.

Signed-off-by: Oleg Utkin <oleg.utkin@nonlogical.io>
NonLogicalDev added a commit to NonLogicalDev/fork.lib.go.go-git that referenced this issue May 17, 2019
…Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.

Signed-off-by: Oleg Utkin <oleg.utkin@nonlogical.io>
NonLogicalDev added a commit to NonLogicalDev/fork.lib.go.go-git that referenced this issue May 17, 2019
…Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.

Signed-off-by: Oleg Utkin <oleg.utkin@nonlogical.io>
@NonLogicalDev
Copy link
Author

Seems like there is a related Issue #1143

novas0x2a pushed a commit to novas0x2a/go-git that referenced this issue Jun 4, 2019
…Fixes src-d#1151

In getHaves, allow the getHavesRef to fail with Object Not found when
iterating over incomplete history, and don't treat it as a fatal error.

Signed-off-by: Oleg Utkin <oleg.utkin@nonlogical.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant