From 802ae768759679c259fd27a77dc279f426669bc9 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 15:15:57 +0100
Subject: [PATCH 01/10] a few accessibility fixes from lighthouse report

---
 src/assets/fonts/material-icons.css     | 1 +
 src/assets/stylesheets/base/_icons.scss | 2 +-
 src/base.html                           | 2 +-
 src/partials/header.html                | 3 ++-
 src/partials/nav.html                   | 2 +-
 src/partials/search.html                | 2 +-
 6 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/assets/fonts/material-icons.css b/src/assets/fonts/material-icons.css
index aa116394c00..c6dfd9bb61d 100644
--- a/src/assets/fonts/material-icons.css
+++ b/src/assets/fonts/material-icons.css
@@ -16,6 +16,7 @@
   font-family: "Material Icons";
   font-style: normal;
   font-weight: 400;
+  font-display: swap;
   src: local("Material Icons"),
        local("MaterialIcons-Regular"),
        url("specimen/MaterialIcons-Regular.woff2") format("woff2"),
diff --git a/src/assets/stylesheets/base/_icons.scss b/src/assets/stylesheets/base/_icons.scss
index 8721fa5ba12..b942dc034f0 100644
--- a/src/assets/stylesheets/base/_icons.scss
+++ b/src/assets/stylesheets/base/_icons.scss
@@ -29,13 +29,13 @@
 // Icon placeholders
 %md-icon {
   font-family: "Material Icons";
+  font-display: swap;
   font-style: normal;
   font-variant: normal;
   font-weight: normal;
   line-height: 1;
   text-transform: none;
   white-space: nowrap;
-  speak: none;
   word-wrap: normal;
   direction: ltr;
 
diff --git a/src/base.html b/src/base.html
index 1e743d80692..f2ddea5fd81 100644
--- a/src/base.html
+++ b/src/base.html
@@ -145,7 +145,7 @@
             href="https://fonts.googleapis.com/css?family={{
               font.text | replace(' ', '+') + ':300,400,400i,700%7C' +
               font.code | replace(' ', '+')
-            }}&display=fallback" />
+            }}&display=swap" />
         <style>
           body, input {
             font-family: "{{ font.text }}", "Helvetica Neue",
diff --git a/src/partials/header.html b/src/partials/header.html
index b5167af917d..806fa3b78dc 100644
--- a/src/partials/header.html
+++ b/src/partials/header.html
@@ -31,11 +31,12 @@
       <div class="md-flex__cell md-flex__cell--shrink">
         <a href="{{ config.site_url | default(nav.homepage.url, true) | url }}"
             title="{{ config.site_name }}"
+            aria-label="{{ config.site_name }}"
             class="md-header-nav__button md-logo">
           {% if config.theme.logo.icon %}
             <i class="md-icon">{{ config.theme.logo.icon }}</i>
           {% else %}
-            <img src="{{ config.theme.logo | url }}" width="24" height="24" />
+            <img alt="logo" src="{{ config.theme.logo | url }}" width="24" height="24" />
           {% endif %}
         </a>
       </div>
diff --git a/src/partials/nav.html b/src/partials/nav.html
index 5791d0916b0..72c2059d757 100644
--- a/src/partials/nav.html
+++ b/src/partials/nav.html
@@ -30,7 +30,7 @@
       {% if config.theme.logo.icon %}
         <i class="md-icon">{{ config.theme.logo.icon }}</i>
       {% else %}
-        <img src="{{ config.theme.logo | url }}" width="48" height="48" />
+        <img alt="logo" src="{{ config.theme.logo | url }}" width="48" height="48" />
       {% endif %}
     </a>
     {{ config.site_name }}
diff --git a/src/partials/search.html b/src/partials/search.html
index 6a2a270ff2a..6aa37ba5377 100644
--- a/src/partials/search.html
+++ b/src/partials/search.html
@@ -27,7 +27,7 @@
   <label class="md-search__overlay" for="__search"></label>
   <div class="md-search__inner" role="search">
     <form class="md-search__form" name="search">
-      <input type="text" class="md-search__input" name="query"
+      <input type="text" class="md-search__input" aria-label="search" name="query"
           placeholder="{{ lang.t('search.placeholder') }}"
           autocapitalize="off" autocorrect="off" autocomplete="off"
           spellcheck="false" data-md-component="query"

From 356735b65a8da8b8ff0d7a163e6501e136073827 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 15:22:40 +0100
Subject: [PATCH 02/10] add rel="noopener" to external links

---
 src/partials/footer.html | 4 ++--
 src/partials/social.html | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/partials/footer.html b/src/partials/footer.html
index de9f0e8ad0a..b0dba02b9cf 100644
--- a/src/partials/footer.html
+++ b/src/partials/footer.html
@@ -89,9 +89,9 @@
           </div>
         {% endif %}
         powered by
-        <a href="https://www.mkdocs.org">MkDocs</a>
+        <a href="https://www.mkdocs.org" rel="noopener">MkDocs</a>
         and
-        <a href="https://squidfunk.github.io/mkdocs-material/">
+        <a href="https://squidfunk.github.io/mkdocs-material/" rel="noopener">
           Material for MkDocs</a>
       </div>
 
diff --git a/src/partials/social.html b/src/partials/social.html
index 97fc14b791b..b9edea85ab9 100644
--- a/src/partials/social.html
+++ b/src/partials/social.html
@@ -26,7 +26,7 @@
     <link rel="stylesheet" type="text/css"
         href="{{ 'assets/fonts/font-awesome.css' | url }}" />
     {% for social in config.extra.social %}
-      <a href="{{ social.link }}" class="md-footer-social__link
+      <a href="{{ social.link }}" rel="noopener" class="md-footer-social__link
             fa fa-{{ social.type }}"></a>
     {% endfor %}
   </div>

From b43233e2ca926c9b6f381124b448cf723b38ec15 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 15:26:31 +0100
Subject: [PATCH 03/10] add title attribute to social links

---
 src/partials/social.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/partials/social.html b/src/partials/social.html
index b9edea85ab9..8f4d58e04d6 100644
--- a/src/partials/social.html
+++ b/src/partials/social.html
@@ -26,7 +26,7 @@
     <link rel="stylesheet" type="text/css"
         href="{{ 'assets/fonts/font-awesome.css' | url }}" />
     {% for social in config.extra.social %}
-      <a href="{{ social.link }}" rel="noopener" class="md-footer-social__link
+      <a href="{{ social.link }}" rel="noopener" title="{{ social.type }}" class="md-footer-social__link
             fa fa-{{ social.type }}"></a>
     {% endfor %}
   </div>

From fc0a1a73b2cd8828015b6ef12aaf8a883f3a0150 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 15:39:36 +0100
Subject: [PATCH 04/10] add mimetype to manifest link and allow it to work
 behind auth

---
 src/base.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/base.html b/src/base.html
index f2ddea5fd81..9e5a3d77e34 100644
--- a/src/base.html
+++ b/src/base.html
@@ -165,7 +165,7 @@
 
     <!-- Progressive Web App Manifest -->
     {% if config.extra.manifest %}
-      <link rel="manifest" href="{{ config.extra.manifest | url }}">
+      <link rel="manifest" type="application/manifest+json" href="{{ config.extra.manifest | url }}" crossorigin="use-credentials">
     {% endif %}
 
     <!-- Custom stylesheets -->

From 8dfd5254c05c9c689352817ced5a659314fa778d Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 15:39:59 +0100
Subject: [PATCH 05/10] add font-display: swap to all the places where external
 fonts are used

---
 src/assets/fonts/font-awesome.css       | 1 +
 src/assets/fonts/material-icons.css     | 1 +
 src/assets/stylesheets/base/_icons.scss | 2 +-
 src/base.html                           | 2 ++
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/assets/fonts/font-awesome.css b/src/assets/fonts/font-awesome.css
index b569bb4d9cb..02200d8b0ca 100644
--- a/src/assets/fonts/font-awesome.css
+++ b/src/assets/fonts/font-awesome.css
@@ -4,6 +4,7 @@
  */
 
 @font-face {
+  font-display: swap;
   font-family: FontAwesome;
   font-style: normal;
   font-weight: 400;
diff --git a/src/assets/fonts/material-icons.css b/src/assets/fonts/material-icons.css
index c6dfd9bb61d..a806cde6f84 100644
--- a/src/assets/fonts/material-icons.css
+++ b/src/assets/fonts/material-icons.css
@@ -13,6 +13,7 @@
  */
 
 @font-face {
+  font-display: swap;
   font-family: "Material Icons";
   font-style: normal;
   font-weight: 400;
diff --git a/src/assets/stylesheets/base/_icons.scss b/src/assets/stylesheets/base/_icons.scss
index b942dc034f0..3197d7212e5 100644
--- a/src/assets/stylesheets/base/_icons.scss
+++ b/src/assets/stylesheets/base/_icons.scss
@@ -28,8 +28,8 @@
 
 // Icon placeholders
 %md-icon {
-  font-family: "Material Icons";
   font-display: swap;
+  font-family: "Material Icons";
   font-style: normal;
   font-variant: normal;
   font-weight: normal;
diff --git a/src/base.html b/src/base.html
index 9e5a3d77e34..231fe3cdf17 100644
--- a/src/base.html
+++ b/src/base.html
@@ -148,10 +148,12 @@
             }}&display=swap" />
         <style>
           body, input {
+            font-display: swap;
             font-family: "{{ font.text }}", "Helvetica Neue",
               Helvetica, Arial, sans-serif;
           }
           pre, code, kbd {
+            font-display: swap;
             font-family: "{{ font.code }}", "Courier New",
               Courier, monospace;
           }

From 4af33789f3c44184a537b68accf968e1fe3feeab Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 16:04:14 +0100
Subject: [PATCH 06/10] remove font-display: swap from icon fonts

---
 src/assets/fonts/font-awesome.css       | 1 -
 src/assets/fonts/material-icons.css     | 2 --
 src/assets/stylesheets/base/_icons.scss | 1 -
 3 files changed, 4 deletions(-)

diff --git a/src/assets/fonts/font-awesome.css b/src/assets/fonts/font-awesome.css
index 02200d8b0ca..b569bb4d9cb 100644
--- a/src/assets/fonts/font-awesome.css
+++ b/src/assets/fonts/font-awesome.css
@@ -4,7 +4,6 @@
  */
 
 @font-face {
-  font-display: swap;
   font-family: FontAwesome;
   font-style: normal;
   font-weight: 400;
diff --git a/src/assets/fonts/material-icons.css b/src/assets/fonts/material-icons.css
index a806cde6f84..aa116394c00 100644
--- a/src/assets/fonts/material-icons.css
+++ b/src/assets/fonts/material-icons.css
@@ -13,11 +13,9 @@
  */
 
 @font-face {
-  font-display: swap;
   font-family: "Material Icons";
   font-style: normal;
   font-weight: 400;
-  font-display: swap;
   src: local("Material Icons"),
        local("MaterialIcons-Regular"),
        url("specimen/MaterialIcons-Regular.woff2") format("woff2"),
diff --git a/src/assets/stylesheets/base/_icons.scss b/src/assets/stylesheets/base/_icons.scss
index 3197d7212e5..a7024e66bbc 100644
--- a/src/assets/stylesheets/base/_icons.scss
+++ b/src/assets/stylesheets/base/_icons.scss
@@ -28,7 +28,6 @@
 
 // Icon placeholders
 %md-icon {
-  font-display: swap;
   font-family: "Material Icons";
   font-style: normal;
   font-variant: normal;

From a7a3f6aeb9744a4b2c310cc035e379234cca5538 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 16:41:32 +0100
Subject: [PATCH 07/10] removed font-display from style blocks in base

---
 src/base.html | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/base.html b/src/base.html
index 231fe3cdf17..9e5a3d77e34 100644
--- a/src/base.html
+++ b/src/base.html
@@ -148,12 +148,10 @@
             }}&display=swap" />
         <style>
           body, input {
-            font-display: swap;
             font-family: "{{ font.text }}", "Helvetica Neue",
               Helvetica, Arial, sans-serif;
           }
           pre, code, kbd {
-            font-display: swap;
             font-family: "{{ font.code }}", "Courier New",
               Courier, monospace;
           }

From 2aaa3ea2cac6887d26f2845c135be375067071bc Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 17:13:20 +0100
Subject: [PATCH 08/10] add target="_blank" to social links

---
 src/partials/social.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/partials/social.html b/src/partials/social.html
index 8f4d58e04d6..8942005b806 100644
--- a/src/partials/social.html
+++ b/src/partials/social.html
@@ -26,7 +26,7 @@
     <link rel="stylesheet" type="text/css"
         href="{{ 'assets/fonts/font-awesome.css' | url }}" />
     {% for social in config.extra.social %}
-      <a href="{{ social.link }}" rel="noopener" title="{{ social.type }}" class="md-footer-social__link
+      <a href="{{ social.link }}" target="_blank" rel="noopener" title="{{ social.type }}" class="md-footer-social__link
             fa fa-{{ social.type }}"></a>
     {% endfor %}
   </div>

From c7d505f5a20a2a1ca87320d7278e8becb90ff81e Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 17:13:59 +0100
Subject: [PATCH 09/10] switch base fonts grabbed from Google back to
 display:fallback

As per recommendation from https://developers.google.com/web/updates/2016/02/font-display#fallback
---
 src/base.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/base.html b/src/base.html
index 9e5a3d77e34..eb334487678 100644
--- a/src/base.html
+++ b/src/base.html
@@ -145,7 +145,7 @@
             href="https://fonts.googleapis.com/css?family={{
               font.text | replace(' ', '+') + ':300,400,400i,700%7C' +
               font.code | replace(' ', '+')
-            }}&display=swap" />
+            }}&display=fallback" />
         <style>
           body, input {
             font-family: "{{ font.text }}", "Helvetica Neue",

From d6c8ba3f60863c7ea0a4ed1a92d44ea4e93e40f7 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 17:25:36 +0100
Subject: [PATCH 10/10] add target="_blank" to the footer links as well

---
 src/partials/footer.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/partials/footer.html b/src/partials/footer.html
index b0dba02b9cf..95b7caca6df 100644
--- a/src/partials/footer.html
+++ b/src/partials/footer.html
@@ -89,9 +89,9 @@
           </div>
         {% endif %}
         powered by
-        <a href="https://www.mkdocs.org" rel="noopener">MkDocs</a>
+        <a href="https://www.mkdocs.org" target="_blank" rel="noopener">MkDocs</a>
         and
-        <a href="https://squidfunk.github.io/mkdocs-material/" rel="noopener">
+        <a href="https://squidfunk.github.io/mkdocs-material/" target="_blank" rel="noopener">
           Material for MkDocs</a>
       </div>