Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipelines.py #157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update pipelines.py #157

wants to merge 2 commits into from

Conversation

Mikehade
Copy link

@Mikehade Mikehade commented Mar 15, 2023 •
edited

Update pipelines.py by adding stratify parameter to train_test_split function of the sklearn library

  • closes Adjust the train_test_split parts in pipelines #91 (Replace 91 with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature.
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Updated documentation.

@Mikehade
Update pipelines.py
63e18a9 
Update pipelines.py by adding stratify parameter to train_test_split function of the sklearn library
@Mikehade
Copy link
Author

Stratify parameter added added

momegas
momegas approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@momegas momegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@momegas
Copy link
Member

momegas commented Mar 20, 2023

Some tests are failing 🥶

@Mikehade
Copy link
Author

I will check out the errors to find a solution

@Mikehade
Copy link
Author

I have corrected the stratify variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momegas momegas momegas approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust the train_test_split parts in pipelines
2 participants
@Mikehade @momegas