Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion matrix schema alignment #143

Open
stavrostheocharis opened this issue Feb 17, 2023 · 1 comment
Open

Confusion matrix schema alignment #143

stavrostheocharis opened this issue Feb 17, 2023 · 1 comment
Labels
good first issue Good for newcomers refactor This issue refers to changing code without producing a new feature

Comments

@stavrostheocharis
Copy link
Contributor

stavrostheocharis commented Feb 17, 2023 •
edited

Description
In schema "PerformanceMetric" there is a misalignment between the BinaryClassificationMetricsPipelineResult and the MultiClassificationMetricsPipelineResult.

In the first one the true_negative, false_positive, etc. are on the outer level. On the other side we have them inside a confusion matrix attribute: confusion_matrix: Dict[str, ConfusionMatrix]

Solution
Make them aligned. Add in BinaryClassificationMetricsPipelineResult a new attribute confusion_matrix and include inside the corresponding metrics.

Note: Maybe changes inside other parts of the code may be needed!
@stavrostheocharis stavrostheocharis added the enhancement New feature or request label Feb 17, 2023
@momegas momegas added good first issue Good for newcomers refactor This issue refers to changing code without producing a new feature and removed enhancement New feature or request labels Feb 17, 2023
@sinnec
Copy link
Contributor

sinnec commented Mar 9, 2023

Changes will be needed in run_create_alerts_pipeline as well to match the changed schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor This issue refers to changing code without producing a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momegas @sinnec @stavrostheocharis