Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inference with actuals #136

Open
stavrostheocharis opened this issue Feb 15, 2023 · 1 comment
Open

Update inference with actuals #136

stavrostheocharis opened this issue Feb 15, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stavrostheocharis
Copy link
Contributor

Description

The user can only upload the actuals together with the other data in the log_inferences function. There should be another function in SDK in order that the user will be able to solely upload his actuals in the future.

Describe the solution you'd like

Here the user has to give also his own ID for the inferences in order to match them with our side (for future reference). This has to do with the other schemas of WB and the user has to always provide us with his own ID for the inferences. So we have also to update the inference schemas in order to also capture this "foreign id".

@stavrostheocharis stavrostheocharis added discussion needed This issue needs some discussion to move forward enhancement New feature or request tech debt labels Feb 15, 2023
@momegas momegas changed the title Solely logging of actuals Update inference with actuals Feb 17, 2023
@momegas
Copy link
Member

momegas commented Feb 17, 2023

We also need to create an API endpoint because at the moment it does not exist. I propose something like PATCH /inference-rows/{inference_row_id}

@momegas momegas added good first issue Good for newcomers and removed discussion needed This issue needs some discussion to move forward tech debt labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants