Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user has to give together the timestamp in a column with the processed Dataframe #135

Open
2 tasks
stavrostheocharis opened this issue Feb 15, 2023 · 3 comments
Labels
discussion needed This issue needs some discussion to move forward enhancement New feature or request

Comments

@stavrostheocharis
Copy link
Contributor

stavrostheocharis commented Feb 15, 2023

Description

The user has to give together the timestamp in a column with the processed Dataframe

Solution

Inside the log_inferences function we have to take timestamps as a new series and construct the schemas as we already do (without including the time series into the processed) as it is now. Instead of timestamps the user has to give the name of the timestamps column.

Additional context
model_id str,
John Zaras, 3 months ago 11 author (John Zaras)

  • Add the timestamps as described
  • Fix the typing in the arguments given (actuals should be Union[...]
@stavrostheocharis stavrostheocharis added discussion needed This issue needs some discussion to move forward enhancement New feature or request labels Feb 15, 2023
@momegas
Copy link
Member

momegas commented Feb 17, 2023

Can you elaborate a bit more on this? Not sure I understand it

@momegas
Copy link
Member

momegas commented Feb 28, 2023

This is a bug right?

@stavrostheocharis
Copy link
Contributor Author

Not exactly it was chosen to be used as it is. But i believe that the proposed way is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed This issue needs some discussion to move forward enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants