Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nonprocessed Optional for the Inferences #134

Open
stavrostheocharis opened this issue Feb 15, 2023 · 3 comments
Open

Make nonprocessed Optional for the Inferences #134

stavrostheocharis opened this issue Feb 15, 2023 · 3 comments
Assignees
@sinnec
Labels
good first issue Good for newcomers refactor This issue refers to changing code without producing a new feature

Comments

@stavrostheocharis
Copy link
Contributor

stavrostheocharis commented Feb 15, 2023 •
edited

Description

For the user it should be optional to upload the nonprocessed data for some reasons: a) we do not actually need them for now. Only for enhancement in the future for some reasons and b) maybe she does not want to give the real categorical vars but only the processed/renamed ones.

Solution

Just change the schema and also check the necessity use of the nonprocessed data inside the functions.

Additional context

John Zaras, 3 months ago 1 author (John Zaras)
@stavrostheocharis stavrostheocharis added the enhancement New feature or request label Feb 15, 2023
@momegas momegas added refactor This issue refers to changing code without producing a new feature good first issue Good for newcomers and removed enhancement New feature or request labels Feb 17, 2023
@sinnec
Copy link
Contributor

sinnec commented Mar 23, 2023

Should the nonprocessed data be also optional in dataset_rows?

@sinnec
Copy link
Contributor

sinnec commented Mar 23, 2023

@momegas I've started working on it!

@momegas
Copy link
Member

momegas commented Mar 23, 2023

Yes they should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinnec sinnec

Labels
good first issue Good for newcomers refactor This issue refers to changing code without producing a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momegas @sinnec @stavrostheocharis