Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future release 3.13 is ready for translation! #3452

Open
mgrojo opened this issue Sep 7, 2023 · 39 comments
Open

Future release 3.13 is ready for translation! #3452

mgrojo opened this issue Sep 7, 2023 · 39 comments

Comments

@mgrojo
Copy link
Member

mgrojo commented Sep 7, 2023

We are in the process of releasing our next stable version (3.13.0) with many corrections and enhancements.

This is your opportunity to make DB4S better by translating it to your language or updating the translation for this release (when available).

Available nightly builds

You can install one of the nightly builds for your platform to see strings in context.

Instructions

The *.ts files are already updated on the master branch, and we don't plan to modify the strings unless needed to include some correction.

You can read brief indications here about how to do it. Team members will assist you in the process, in case you had any doubt.

Notifications

I'll ping here all the translators who have helped us in the past, so they get a notification. Please, report back if you want to help again. When there are more than one volunteer, they can share out the work and/or review each other translations. Try to coordinate each other, otherwise you could do redundant work.

lang complete untranslated texts translators
ar_SA 191 @SafaAlfulaij
cs 790 @MrMarmelade
de 249 @FriedrichFroebel
en_GB 1123 @glawrence
es_ES 191 @lulol, @mgrojo
fa @khashayarxy
fr 192 @mvt91
id 138 @atriwidada
it 264 @Feyn-Man, @GortiZ6
ja 208 @hrwatahiki
ko_KR 22 @lucydodo, @neozest, @progh2
nl 138 @Codifier
pl 140 @bartlomiej-przymus, @wojnilowicz
pt_BR 257 @bernardosulzbach
ru 507 @schdub, @zvova7890, @VanDerSam
sv 1076 Jan-Erik (via @TeLLie)
tr 265 @firateski
uk_UA 857 @keedhost
zh 145 @bssthu, @mercury233, @yfdyh000
zh_TW 138 @PeterDaveHello
other Your name here!

Thanks and happy translation!

Source string changes after translation started

Due date

We don't have a planned date yet, but most probably by the end of September.

@mgrojo mgrojo added this to the 3.13.0 - Future release milestone Sep 7, 2023
@mgrojo mgrojo pinned this issue Sep 7, 2023
@lucydodo
Copy link
Member

lucydodo commented Sep 8, 2023

Cool, I'll try to have it done by next week at the latest. :)

@atriwidada
Copy link
Contributor

will try to do this weekend

@GortiZ6
Copy link
Contributor

GortiZ6 commented Sep 8, 2023

Done, I added a pull request #3453
@Feyn-Man, feel free to check/fix it :)

@lulol
Copy link
Contributor

lulol commented Sep 8, 2023

@mgrojo If you didn't start the Spanish translation, would you prefer that I translate all pending lines so that you can later review them and make any needed changes or we can split them in half and review each other's work?

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

@mgrojo If you didn't start the Spanish translation, would you prefer that I translate all pending lines so that you can later review them and make any needed changes or we can split them in half and review each other's work?

I haven't started, and I'm happy with any of those options. If you don't really have a preference, let's split the file and then we review each other's work. Around line 4000 is the half, but I don't know if the share of pending translations is fair, but more or less so.

@lulol
Copy link
Contributor

lulol commented Sep 8, 2023

@mgrojo Ok. There are 197 unfinished lines and the half point is at:

<source>&amp;Open Database</source>
<translation type="unfinished"></translation>

I can start from that line down.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

Perfect, @lulol, I'll take the first half until that line, then.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

Hint for translation: try to not repeat the global key accelerators, that is, underscored letters in main menubar, main toolbar and main tabs, otherwise they cannot be used or require a second key press. If there are no more available letters, you might choose to sacrifice the actions that already have keyboard shortcuts with Ctrl like Open Database or New Database. The change comes from #3450.

@mvt91
Copy link
Contributor

mvt91 commented Sep 8, 2023 via email

@hrwatahiki
Copy link
Contributor

I've started translate this to ja.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

Is there someone who works on the French translation ?

Hi Michel,

No, nobody is working on the French translation yet, as far as I know.

mgrojo added a commit that referenced this issue Sep 8, 2023
[CHG] Updated italian translation for 3.13 release

Issue #3452.
mgrojo added a commit that referenced this issue Sep 8, 2023
Update Indonesian translation.

Issue #3452
mgrojo added a commit that referenced this issue Sep 8, 2023
translation: Update Korean translation for v3.13 release

Issue #3452
@wojnilowicz
Copy link
Contributor

In the future please ping once. Now I get a lot of spam unless I unsubscribe from this thread, which I haven't subscribed in the first place.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

In the future please ping once. Now I get a lot of spam unless I unsubscribe from this thread, which I haven't subscribed in the first place.

Sorry about that. Yes, you can always unsubscribe, that's the way to opt out. For the future, we will think how to do it in another way. Maybe an announcement in Discussions and then an issue for the actual work only for the contributing people.

@mvt91
Copy link
Contributor

mvt91 commented Sep 8, 2023 via email

@mgrojo
Copy link
Member Author

mgrojo commented Sep 8, 2023

What's the dead line ?

Let's say end of September. We are not in a hurry, although the pull requests are coming quicker than I expected.

@mvt91
Copy link
Contributor

mvt91 commented Sep 9, 2023 via email

@bernardosulzbach
Copy link
Contributor

I'm no longer interested in helping with localization. Nowadays, I have too little free time that I have to allocate across too many different projects, and I'm afraid I don't enjoy translating enough to justify doing it.

I hope you and other DB Browser for SQLite contributors and users will understand. A huge number of people speak both Portuguese and English, so hopefully someone will be able to carry on from where I stopped.

@FriedrichFroebel
Copy link
Contributor

Some general stuff I stumbled upon which could be improved:

  • Split the main HTML of the About Dialog with multiple strings to simplify translation. This might apply to the other HTML stuff as well where the string itself is not formatted as well.
  • <source>Ignored environment variable(DB4S_SETTINGS_FILE) value : </source>
    misses a whitespace before the brace.
  • <source>Select the action to apply to the dropped file(s). &lt;br/&gt;Note: only &apos;Import&apos; will process more than one file.</source>
    is reported as missing the placeholder %n/%Ln in the translation.
  • <source>(X,Y) Return the arctangent of Y/X. The result is in radians. he result is placed into correct quadrant depending on the signs of X and Y.</source>
    misses the first character of the last sentence.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 9, 2023

@bernardosulzbach, that is understandable. Let's hope someone else volunteers to continue the Portuguese translation.

@FriedrichFroebel

Some general stuff I stumbled upon which could be improved:

* Split the main HTML of the About Dialog with multiple strings to simplify translation. This might apply to the other HTML stuff as well where the string itself is not formatted as well.

Yes, you're right. I suppose it's late now. We should take into account for future versions.

* https://github.com/sqlitebrowser/sqlitebrowser/blob/5f494ea65370aab3a239c125410fb66a08f41879/src/translations/sqlb_de.ts#L143
   misses a whitespace before the brace.

Yes, I can fix the source and the translations later. It's better if the translations already come with appropriate punctuation.

* https://github.com/sqlitebrowser/sqlitebrowser/blob/5f494ea65370aab3a239c125410fb66a08f41879/src/translations/sqlb_de.ts#L4404
   is reported as missing the placeholder `%n/%Ln` in the translation.

I'll take a look. I don't know if it can be done without referencing the %n/%Ln, which wasn't foreseen in this case. Otherwise, it is too late too.

@lulol and me are also discussing another very special case, which is:

        <location filename="../EditDialog.cpp" line="1091"/>
        <source>Type: %1 Image; Size: %2x%3 pixel(s)</source>

Given that in this case the 1 case is very unusual, and in fact, n would be the result of a multiplication. Do you think it makes sense to transform it into a plural-supported way? n should be %2 * %3, and will not appear in the string (I don't know if that's even possible with Qt).

* https://github.com/sqlitebrowser/sqlitebrowser/blob/5f494ea65370aab3a239c125410fb66a08f41879/src/translations/sqlb_de.ts#L6912
   misses the first character of the last sentence.

Ok, it has already been reported.

There are two typos in the original English, not yet merged to avoid conflicts: #3454 and #3456. Don't worry about them, this can be fixed later for all translation files.

mgrojo added a commit that referenced this issue Sep 9, 2023
mgrojo added a commit that referenced this issue Sep 9, 2023
Update Indonesian translation. Issue #3452.
mgrojo added a commit that referenced this issue Sep 9, 2023
Complete first half of the Spanish translation for v3.13. Issue #3452.
mgrojo added a commit that referenced this issue Sep 9, 2023
- Concordance.
- Avoid Title Case.
- Accented vowels do not work as accelerators.
- Clearer translation for Upload as suggested by @lulol.
- Other minor.

Issue #3452.
mgrojo added a commit that referenced this issue Sep 9, 2023
@mgrojo
Copy link
Member Author

mgrojo commented Sep 9, 2023

In any case, should I add the %n even at risk of breaking the current translations? Or we can leave it as is?

We might want to at least add a general translator notice there like we already use for some strings.

Ok. Added notice in the branch where I'm fixing things affecting translations to avoid conflicts (#3456). Example:

+    <message numerus="yes">
+        <location filename="../MainWindow.cpp" line="1849"/>
+        <source>Select the action to apply to the dropped file(s). &lt;br/&gt;Note: only &apos;Import&apos; will process more than one file.</source>
+        <comment>Note for translation: Although there is no %n in the original, you can use the numerus-form to adjust &apos;files(s)&apos; and remove the note when n = 1. Including %n in the translation will also work.</comment>
+        <translation>
+            <numerusform>Seleccione la acción a aplicar al archivo.</numerusform>
+            <numerusform>Seleccione la acción a aplicar a los %n archivos soltados.&lt;br/&gt;Nota: sólo «Importar» procesará más de un archivo.</numerusform>
+        </translation>
+    </message>

Given that in this case the 1 case is very unusual, and in fact, n would be the result of a multiplication. Do you think it makes sense to transform it into a plural-supported way? n should be %2 * %3, and will not appear in the string (I don't know if that's even possible with Qt).

This actually does not matter for German, as both singular and plural are the same word in this case, so I do not have any clear opinion on this. But leaving it with the braces should at least not hurt from my point of view.

Ok. Nothing changed for the moment.

mgrojo added a commit that referenced this issue Sep 13, 2023
Japanese translation for v3.13.
See issue  #3452.
@mgrojo
Copy link
Member Author

mgrojo commented Oct 11, 2023

Anyone working on a translation who wants to include it in v3.13? @mvt91?

@mvt91
Copy link
Contributor

mvt91 commented Oct 11, 2023 via email

@mgrojo
Copy link
Member Author

mgrojo commented Oct 11, 2023

Hi Manuel, I'm sorry, I didn't have time to do it. As you know, when you're retired, your planning is growing up ! Have you an idea of the work to do ? If I remember, the dead line was the end of September ? Best regards

There are 192 messages to be translated. The original deadline was end of September, but it was tentative, we can wait if you plan to do it. If you need help, let's ping people who have contributed typo corrections for French in the past, maybe they want to share with you the effort: @vlakoff, @hydrargyrum, @vuod.

@mvt91
Copy link
Contributor

mvt91 commented Oct 11, 2023 via email

PeterDaveHello added a commit to PeterDaveHello/sqlitebrowser that referenced this issue Oct 12, 2023
- Translate new strings
- Remove vanished strings
- Improve some translation
PeterDaveHello added a commit to PeterDaveHello/sqlitebrowser that referenced this issue Oct 12, 2023
- Translate new strings
- Remove vanished strings
- Improve some translation
mgrojo added a commit that referenced this issue Oct 12, 2023
@mvt91
Copy link
Contributor

mvt91 commented Oct 14, 2023 via email

@justinclift
Copy link
Member

justinclift commented Oct 14, 2023

@mvt91 GitHub doesn't attach files from email, so you'll probably need to add it via the GitHub web interface. 😉

@mvt91
Copy link
Contributor

mvt91 commented Oct 14, 2023 via email

@mvt91
Copy link
Contributor

mvt91 commented Oct 14, 2023

The file (need to rename it and remove the .txt suffix)
sqlb_fr 3.12.3.MVT.ts.txt

Done :)

@lucydodo
Copy link
Member

Hi @mvt91 Thanks for contribution. :)

I've some errors : Translation does not contain the necessary %n/%Ln place marker.

I've checked these warning in some translations of MainWindow context, and I'm guessing it's a bug on Qt Linguist's end. Other similar translations are showing the same warning. Probably because we're uisng <br> for newline instead of \n.

When I make a commit, would you mind giving me your email address so I can commit as a co-author? If you don't feel comfortable giving out your email in a public place, you can contact me at my email: seongtaejg at gmail dot com
Of course, this is optional, and if you don't want to leave commit as a co-author, just let me know :)

@mgrojo
Copy link
Member Author

mgrojo commented Oct 14, 2023

Hi Manuel, Here is the file translated. I've some errors : Translation does not contain the necessary %n/%Ln place marker. I don't undertand what was the problem.

The warnings are because the plural forms have not been used. These plural forms are not mandatory (in fact, the original English texts don't have this possibility), but they are nice to have.

Using Linguist, it can be fixed in this way (supposing that the French grammar is correct):
imagen

In the raw TS file:

    <message numerus="yes">
        <location filename="../EditDialog.cpp" line="927"/>
        <location filename="../EditDialog.cpp" line="1117"/>
        <source>Type: Text / Numeric; Size: %n character(s)</source>
        <translation>
            <numerusform>Type : Texte / Numérique ; Taille : %n caractère</numerusform>
            <numerusform>Type : Texte / Numérique ; Taille : %n caractères</numerusform>
        </translation>
    </message>

It's similar to what was mentioned here: #3452 (comment)

@lucydodo
Copy link
Member

Hi @mgrojo Thanks for the great information. :)
Here's the translation with the warning I mentioned above, I wonder if this is a bug on Qt's side?
Or is there something else I'm not aware of?

Screenshot 2023-10-14 at 21 58 47

@mvt91
Copy link
Contributor

mvt91 commented Oct 14, 2023 via email

@mgrojo
Copy link
Member Author

mgrojo commented Oct 14, 2023

Hi @lucydodo. OK, that's a particular case and it's the trickiest. The question is that, in the source code, we have a message that includes the n parameter in the call, which is used to control the plural form to be used. Usually, this original message includes the %n in the message itself, so the involved number is present. In this case, we don't have the %n text, so Qt should complain when extracting the message, or never, but not when the translations are done, because they're following the path set by the original.

If you really want to silence that warning, you have this option (using English to English, so we all understand):
imagen

After the release, we might think in adding %n in the source message.

See also this: ff9981f

@mvt91
Copy link
Contributor

mvt91 commented Oct 14, 2023

Hi Manuel,

I've corrected the 2 or 3 sentences in which the plural can be invoked.
There are still 2 "warning" errors about an end-of-sentence character that he doesn't like; I've looked in the file, but the format seems to comply. I don't think it's too important (main window).
The new file (sqlb_en 3.12.3.MVT-2.ts.txt) is attached.
Thanks
sqlb_fr 3.12.3.MVT-2.ts.txt

@lucydodo
Copy link
Member

@mgrojo Thank you very much. It was a great help to me. :)

mgrojo pushed a commit that referenced this issue Oct 14, 2023
@mgrojo
Copy link
Member Author

mgrojo commented Oct 14, 2023

@mvt91 Thanks! I've just committed it.

@lucydodo, by the way, you can always do this to attribute something to a GitHub user, even if you only know their user-id.

git commit --author="mvt91 <mvt91@users.noreply.github.com>" -m "French translation by mvt91 #3452"

That e-mail is the one used by GitHub when a user configures the e-mail as private. GitHub recognizes it and attributes the work to the user.

Note: Later, when pushing this, I reused a command in my history for another repo, and I inadvertently run git push --all. Now I'm cleaning the mess; I pushed all the local branches that I've accumulated over the years in my local repository. 😄

@lucydodo
Copy link
Member

I didn't know that. Thanks for letting me know. 😄

mgrojo added a commit that referenced this issue Dec 10, 2023
Update Polish translation
Issue #3452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests