Try to improve hybrid property #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it doesnt work, my other recipe must have relied upon the way sqlalchemy-stubs works. feel free to close if theres no other ideas |
|
There is an issue also with the current version in master. Like if you try the master branch, with the example in hybrid.py you get this: obj = SomeModel()
reveal_type(obj.hp)this is clearly not correct. I think this may be a mypy issue, since pylance (on vscode) does correctly infer the type (to any in master, to the correct return value with this branch) I'm not sure if the plugin has something to with this tough. Edit: no, removing the plugin definition from setup.cfg does not seem to make any difference |
|
closing since for v2 we went on another direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a try of using the mikes provided code in hybrids but it does not work propertly. Can you take a look @zzzeek ?
Description
Fixes: #171
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!