-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when testing dialect with an exclusion #4249
Comments
Changes by Patrick Buxton:
|
Michael Bayer (@zzzeek) wrote: your setup.py seems to be defaulting to python unittest, which is not supported, on both Python 2 and Python 3 I get essentially this error:
can't run with py.test because you don't have a [db] section in your setup.cfg. The test suite should be set up as documented at: https://github.com/zzzeek/sqlalchemy/blob/master/README.unittests.rst I tried putting a standalone @Property in a local test/reqriements.py like you have above and no error is generated, it skips the JSON tests as expected. |
Michael Bayer (@zzzeek) wrote: oh sorry, I meant: https://github.com/zzzeek/sqlalchemy/blob/master/README.dialects.rst |
Patrick Buxton wrote: Apologies, I gave you incorrect info. Once the repo is cloned, please git checkout the identity_column branch where I had made the changes to the setup.cfg |
Changes by Patrick Buxton:
|
Michael Bayer (@zzzeek) wrote: still cant reproduce anything, I can change the URL in setup.cfg to something else and am not getting that error. A bunch of tests fail because it's running against MySQL or SQLite, but nothing goes wrong with the JSON tests. setup.py seems to indicate I need pyhdb, but the test suite wants to import hdbcli and according to https://blogs.sap.com/2017/07/26/sap-hana-2.0-sps02-new-client-interface-features/ I have to go through an enormous proprietary registration / download / install process which appears to be windows-specific in any case to get to this hdbcli. is it possible you can try testing against some other database that I have access towards and then get this error to reproduce? e.g. like mysql+pymysql, or even just sqlite://. is it possible this is a windows-related issue? |
Patrick Buxton wrote: I changed to point at my Postgresql/Greenplum server and it skips the tests just fine - change back to point at HANA and I get the error. That's all happening on Linux. It's very strange because I can get it to happen in debug locally and I can watch the error occur but it makes no sense really. I can explain what appears to happen even though I don't know why yet: In plugin_base._do_skips it calls _possible_configs_for_cls which looks at the config, sees the one entry, determines is skipped and removes it from the set and returns I'm sorry, I thought you'd be able to see the error straight away - I'll have to debug further and see if I can determine what's going wrong myself. |
Michael Bayer (@zzzeek) wrote: ah, well yes it's sort of a thing you should have, if you don't have one then return like, (0, 0, 0) but also I can certainly try to smooth that out on this end. wow it's just the stringification too, OK |
Michael Bayer (@zzzeek) wrote: easy to reproduce, thanks! |
Michael Bayer (@zzzeek) wrote: here we are: https://gerrit.sqlalchemy.org/#/q/I9124d3ac5484941081127274e6eb71f392fb94f7 just return an empty tuple for now instead of None |
Changes by Michael Bayer (@zzzeek):
|
Michael Bayer (@zzzeek) wrote: Default server_version_info to (0, ) Fixed a bug in the test suite where if an external dialect returned Change-Id: I9124d3ac5484941081127274e6eb71f392fb94f7 → 97e828f |
Changes by Michael Bayer (@zzzeek):
|
Migrated issue, originally created by Patrick Buxton
The error shown below is seen when testing a dialect with:
I'm working on two dialects with this skip in place and it doesn't affect one of them, but I have seen that other people have also had this issue. (MonetDB/sqlalchemy-monetdb#30)
The easiest way to reproduce will be to run the dialect tests:
Just comment out line 62 in testing\provision.py if you don't have a HANA server to point at and you'll still get the error generated even if the tests fail.
The text was updated successfully, but these errors were encountered: