Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default include_schemas to be "from_metadata" #1428

Open
CaselIT opened this issue Feb 17, 2024 · 0 comments
Open

Change the default include_schemas to be "from_metadata" #1428

CaselIT opened this issue Feb 17, 2024 · 0 comments
Milestone

Comments

@CaselIT
Copy link
Member

CaselIT commented Feb 17, 2024

I mean something the following:

  • False -> use only the default schema
  • True -> check all schemas
  • 'from_metadata' -> new default, behave as False if the metadata.schema is None or as True with a name filter to the schema specified in the metadata if the metadata.schema is defined?

I think this new default would do the correct thing in most cases, meaning that an user has to change the include_schemas only if having tables on multiple schemas at the same time

Originally posted by @CaselIT in #1425 (comment)

@CaselIT CaselIT added this to the 1.14 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant