Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate migration still has minor typing issues with mypy #1341

Open
kshpytsya opened this issue Nov 1, 2023 · 1 comment
Open

Autogenerate migration still has minor typing issues with mypy #1341

kshpytsya opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working pep 484 typing related issues PRs (with tests!) welcome

Comments

@kshpytsya
Copy link

The fix for #1253 looks slightly incorrect as the type for down_revision should be Union[str, Sequence[str], None] and not Union[str, None]. down_revision is a tuple for merge revisions.
@kshpytsya kshpytsya added the requires triage New issue that requires categorization label Nov 1, 2023
@CaselIT
Copy link
Member

CaselIT commented Nov 1, 2023

Hi,

Thanks for reporting. If you can send a PR it would be super! Thanks

@CaselIT CaselIT added bug Something isn't working pep 484 typing related issues PRs (with tests!) welcome and removed requires triage New issue that requires categorization labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pep 484 typing related issues PRs (with tests!) welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kshpytsya @CaselIT