{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":635389714,"defaultBranch":"main","name":"aiosqlite","ownerLogin":"sqlalchemy","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-05-02T15:35:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6043126?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1683041765.0","currentOid":""},"activityList":{"items":[{"before":"7b62d07504f5410a1f5a5428c377cd4fa86a496f","after":"07471751dc30b53ee31e0402b77fe7f95c355ce6","ref":"refs/heads/make_close_idempotent","pushedAt":"2023-05-07T12:39:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"zzzeek","name":"Michael Bayer","path":"/zzzeek","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128223?s=80&v=4"},"commit":{"message":"make .close() method idempotent\n\nWhile not explicitly documented in pep-249, repeated calls to\nconnection.close() are customarily accepted without error;\nthe sqlite3 module itself allows multiple calls to .close() as do\npopular asyncio database drivers such as asyncpg.\n\nPrior to this change, the .close() method would attempt to\nexecute a command within the thread, however since the _connection\nattribute is None, it would raise ValueError(\"no active connection\").\nThis ValueError is also not pep-249 compliant since all exceptions\nraised should be subclasses of dbapi.Error, so if the aiosqlite project\nwould prefer repeated .close() calls raise, it should raise within\nthe dbapi.Error hierarchy.\n\nThe change here is submitted by the maintainers of SQLAlchemy\n(https://www.sqlalchemy.org) for the benefit of projects\nto reduce warnings emitted during various connection, application,\nand interpreter shutdown scenarios.","shortMessageHtmlLink":"make .close() method idempotent"}},{"before":"afe64f9fa11c5c77212f52fc8af0776dfc775a7d","after":"7b62d07504f5410a1f5a5428c377cd4fa86a496f","ref":"refs/heads/make_close_idempotent","pushedAt":"2023-05-02T15:37:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"zzzeek","name":"Michael Bayer","path":"/zzzeek","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128223?s=80&v=4"},"commit":{"message":"make .close() method idempotent\n\nWhile not explicitly documented in pep-249, repeated calls to\nconnection.close() are customarily accepted without error;\nthe sqlite3 module itself allows multiple calls to .close() as do\npopular asyncio database drivers such as asyncpg.\n\nPrior to this change, the .close() method would attempt to\nexecute a command within the thread, however since the _connection\nattribute is None, it would raise ValueError(\"no active connection\").\nThis ValueError is also not pep-249 compliant since all exceptions\nraised should be subclasses of dbapi.Error, so if the aiosqlite project\nwould prefer repeated .close() calls raise, it should raise within\nthe dbapi.Error hierarchy.\n\nThe change here is submitted by the maintainers of SQLAlchemy\n(https://www.sqlalchemy.org) for the benefit of projects\nto reduce warnings emitted during various connection, application,\nand interpreter shutdown scenarios.","shortMessageHtmlLink":"make .close() method idempotent"}},{"before":null,"after":"afe64f9fa11c5c77212f52fc8af0776dfc775a7d","ref":"refs/heads/make_close_idempotent","pushedAt":"2023-05-02T15:36:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"zzzeek","name":"Michael Bayer","path":"/zzzeek","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128223?s=80&v=4"},"commit":{"message":"make .close() method idempotent\n\nWhile not explicitly documented in pep-249, repeated calls to\nconnection.close() are customarily accepted without error;\nthe sqlite3 module itself allows multiple calls to .close() as do\npopular asyncio database drivers such as asyncpg.\n\nPrior to this change, the .close() method would attempt to\nexecute a command within the thread, however since the _connection\nattribute is None, it would raise ValueError(\"no active connection\").\nThis ValueError is also not pep-249 compliant since all exceptions\nraised should be subclasses od dbapi.Error, so if the aiosqlite project\nwould prefer repeated .close() calls raise, it should raise within\nthe dbapi.Error hierarchy.\n\nThe change here is submitted by the maintainers of SQLAlchemy\n(https://www.sqlalchemy.org) for the benefit of projects\nto reduce warnings emitted during various connection, application,\nand interpreter shutdown scenarios.","shortMessageHtmlLink":"make .close() method idempotent"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADJ6-lVAA","startCursor":null,"endCursor":null}},"title":"Activity · sqlalchemy/aiosqlite"}