Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable explorer search button keeps pressed after hiding the search field with Esc #9893

Closed
ccordoba12 opened this issue Jul 24, 2019 · 3 comments · Fixed by #9894
Closed
Assignees
Milestone

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Jul 24, 2019

@dalthviz, this is a small bug I noticed after merging PR #9384: if you hide the search field with Esc, then the search button keeps pressed in the interface, as shown in this screenshot (I took it in the light interface theme because it's easier to see):

Selección_002

However, that shouldn't be the case because it's confusing. So after pressing Esc the search button also needs to appear as not pressed.

@dalthviz
Copy link
Member

Should we instead of the Search: label show and x button as in the Find widget? What do you guys think @ccordoba12 @goanpeca ?

Variable Explorer:

imagen

Find Widget:

imagen

@ccordoba12
Copy link
Member Author

I'm +1 so that users quickly realize that the new field in the Variable Explorer is just like any other search field.

@goanpeca
Copy link
Member

I like the idea of keeping the search/find uniform so go for it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants