Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include toggable "Wrap lines" checkbox in Source menu for easy access #7997

Open
CAM-Gerlach opened this issue Oct 4, 2018 · 5 comments · May be fixed by #20090
Open

Include toggable "Wrap lines" checkbox in Source menu for easy access #7997

CAM-Gerlach opened this issue Oct 4, 2018 · 5 comments · May be fixed by #20090

Comments

@CAM-Gerlach
Copy link
Member

Problem Description

Currently, "Wrap lines" is buried deep within the Preferences and only available from there, whereas it is nearly always accessible from the toolbar (or at very least a top-level menu) in most other editors/IDEs, and I toggle it quite frequently in such editors, second only to the "Show blank spaces", which is currently menu-bound. Therefore, both certainly deserve a place on the "Source" (or "Edit") toolbar, as the latter are ideal for functions frequently toggled on or off and where observing the status is helpful.

@goanpeca
Copy link
Member

goanpeca commented Dec 4, 2019

I support adding options to the source menu,

Screen Shot 2019-12-03 at 22 18 28

But I do not agree with adding this to a toolbar.

@CAM-Gerlach
Copy link
Member Author

But I do not agree with adding this to a toolbar.

Could you at least briefly explain your rationale for not wanting either on the toolbar? The other editors I use that have toolbars (Notepad++, Eclipse, MultiCommander), all have both as toolbar buttons by default (except for the show whitespace toolbar button in Eclipse, which is optional), whereas I hardly use any of the current Spyder toolbar buttons other than the working dir widget (e.g. PYTHONPATH manager? Dedicated button to switch to the Find pane?) regularly or ever, as opposed to either accessing the feature via keyboard hotkeys, menus or elsewhere in the UI, or not at all.

The editors that don't have toolbars usually allow you to bind it to a keyboard shortcut, which wouldn't be hard to add in Spyder as an alternative, but given we do have a toolbar it would IMO be best to follow the best practices of other such mainstream editors to make it more easily visible and toggleable for users without having to memorize two more non-standard shortcuts.

@goanpeca
Copy link
Member

goanpeca commented Dec 4, 2019

Could you at least briefly explain your rationale for not wanting either on the toolbar?

Toolbars should only expose important easy to access features not every single feature available. This feels like a secondary thing so it does not deserve in my opinion space on the toolbar, nor do we want to go the Microsoft way of "edit the toolbars as you want". So in the menu it makes sense to me, on the toolbar it does not.

@CAM-Gerlach
Copy link
Member Author

I agree toolbars should focus on only the most commonly accessed features, and I don't think its worth the work and complexity of implementing custom toolbars unless users really ask for them. However, don't you think these are more commonly accessed features than the Python Path Manger and an extra button for the Find pane, which are currently on the toolbar? At least for me, I use them more than any of the existing toolbar buttons combined (aside from the working dir widget). But its not the end of the world, though, especially compared with at least having a toggle as common as word wrap in the Source menu and not buried several layers deep in preferences.

@ccordoba12
Copy link
Member

This could be added to the Source menu and not to a toolbar.

@goanpeca goanpeca removed this from the future milestone Feb 23, 2020
@ccordoba12 ccordoba12 changed the title Include toggable "Wrap lines" and "Show blank spaces" buttons in toolbar for easy access Include toggable "Wrap lines" checkbox in Source menu for easy access Jul 11, 2020
@maurerle maurerle linked a pull request Nov 19, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants