Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline pane is too slow when updating #11084

Closed
bcolsen opened this issue Dec 13, 2019 · 5 comments
Closed

Outline pane is too slow when updating #11084

bcolsen opened this issue Dec 13, 2019 · 5 comments
Assignees
Labels

Comments

@bcolsen
Copy link
Member

bcolsen commented Dec 13, 2019

As a follow up to PR #11010 partially fixing #10992

For large files the outliner updates are still quite slow. You can see the difference after #11010 by closing and opening the outliner pane.

The next step would be to optimize populate_branch or only run partial updates on the document near the change:

def populate_branch(self, editor, root_item, tree_cache=None):

It could also be put into a non-blocking thread as well.

@ccordoba12 ccordoba12 added this to the 4.1.0 milestone Dec 14, 2019
@ccordoba12
Copy link
Member

ccordoba12 commented Dec 14, 2019

Do you have time to do this soon @bcolsen? I'm asking because I plan to do a 4.0.1 release next week with all the optimizations done during these days.

@goanpeca
Copy link
Member

It could also be put into a non-blocking thread as well.

Definitely something to do. On the other hand, we could get rid of most of the code and use the pyls to populate it. But before we can do that we need to add cell capability to the pyls.

@ccordoba12
Copy link
Member

ccordoba12 commented Dec 14, 2019

Definitely something to do. On the other hand, we could get rid of most of the code and use the pyls to populate it. But before we can do that we need to add cell capability to the pyls.

I definitely think we should leave this for Spyder 5. I know is though to maintain for v4, but it could require a big refactoring to move things to the PyLS.

@bcolsen
Copy link
Member Author

bcolsen commented Dec 14, 2019

Do you have time to do this soon @bcolsen? I'm asking because I plan to do a 4.0.1 release next week with all the optimizations done during these days.

I think a 4.0.1 release is would be great. I won't have time in the next week or so, but over the break I'll try to see if there are any simple things I can do to speed it up.

@goanpeca goanpeca removed this from the v4.2.0 milestone Feb 19, 2020
@ccordoba12 ccordoba12 changed the title Speed up outliner updating Outline pane is too slow when updating Apr 16, 2020
@goanpeca goanpeca added type:Bug and removed v4.2.0 labels May 8, 2020
@ccordoba12
Copy link
Member

This no longer applies with the move to use LSP symbols in in 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants