Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parser-based validation for JPQL, SQL, HQL snippets #1236

Closed
martinlippert opened this issue Apr 18, 2024 · 3 comments
Closed

add parser-based validation for JPQL, SQL, HQL snippets #1236

martinlippert opened this issue Apr 18, 2024 · 3 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring-data-support theme: validation type: enhancement

Comments

@martinlippert
Copy link
Member

Add validation logic to the language support for JPQL (etc.) wherever those languages are being used (annotations in Java source code, named query files, etc.).

The validation should report messages from the parser to the user in the form of diagnostics, as usual. The more detailed and fine-grained, the better - depending on that is possible using the parser at hand.

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse theme: spring-data-support for: vscode something that is specific for VSCode theme: validation labels Apr 18, 2024
@martinlippert martinlippert added this to the 4.22.1.RELEASE milestone Apr 18, 2024
@BoykoAlex
Copy link
Contributor

I'd factor out SQL is a separate issue as we don't have SQL parser and semantic token syntax highlighting for SQL. At the moment all SQL support comes from upstream extensions and syntax highlighting for SQL is somewhat restricted by what upstream extensions/plugins provide. There is no semantic tokens syntax highlighting from Boot LS provided for native SQL (but we can change that of course)

@BoykoAlex
Copy link
Contributor

JPQL and HQL are in with 385c35e

@BoykoAlex
Copy link
Contributor

SQL was the last one. Went in with fe953bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring-data-support theme: validation type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants