Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide puristic upgrade support for Spring Boot without including polish recipes #1206

Open
martinlippert opened this issue Mar 11, 2024 · 0 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement

Comments

@martinlippert
Copy link
Member

At the moment, when upgrading a Spring Boot 2.7 application to 3.2, there are a bunch of polish and best practices recipes being applied to the source code that are not really necessary when upgrading to a newer Spring Boot version. For example, some Java 17 upgrade recipe converts string literals into text blocks where appropriate. Some other polish was to remove unnecessary @Autowired annotations (from constructors), or non-necessary @PathVariable params.

We should offer a clean separation between pure upgrade recipes and polish/best practice recipes and run only the puristic upgrade recipes when users execute the upgrade command (from the command palette or the quick fix).

In addition to that we could offer polish and best practices actions as well, but separate.

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring labels Mar 11, 2024
@martinlippert martinlippert added this to the 4.23.0.RELEASE milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants