Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show changes "Preview" rather than "Confirmation" once recipe is applied #1176

Open
BoykoAlex opened this issue Jan 30, 2024 · 0 comments
Open

Show changes "Preview" rather than "Confirmation" once recipe is applied #1176

BoykoAlex opened this issue Jan 30, 2024 · 0 comments
Assignees
@BoykoAlex
Labels
for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Milestone
4.23.0.RELEASE

Comments

@BoykoAlex
Copy link
Contributor

Currently LSP allows to specify needsConfirmation on a workspace edit to show "Refactor Preview" with all changes unchecked. This is rather annoying because to see the changes for a particular file the changes need to check-marked. Check-marking is a manual process with check-mark all action.

It'd be best if rather confirming each change the "Refactor View" had an option just to "preview" changes which would have all changes check-marked allowing use to uncheck any undesired changes.

This is likely to be done in VSCode/LSP

"Refactor Preview" related VSCode issues:
microsoft/vscode#144893
microsoft/vscode#200991 (from me)
microsoft/vscode#156886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Milestone
4.23.0.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex