Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kafka Reply Topic Logic in the KafkaProducerMessageHandler #3616

Open
garyrussell opened this issue Aug 19, 2021 · 0 comments
Open

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Aug 19, 2021

Currently:

		if (replyTopic == null) {
			if (this.replyTopicsAndPartitions.size() == 1) {
				replyTopic = getSingleReplyTopic();
			}
			else {
				throw new IllegalStateException("No reply topic header and no default reply topic can be determined");
			}
		}

However, the ReplyingKafkaTemplate could have already determined a default reply topic - this will need a change to the template to expose its default (if present).

The current mechanism (determineValidReplyTopicsAndPartitions()) does not work because the partition might not have yet been assigned.

@garyrussell garyrussell added this to the Backlog milestone Aug 19, 2021
@artembilan artembilan changed the title Improve Kafka Reply Topic Logic Improve Kafka Reply Topic Logic in the KafkaProducerMessageHandler Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants