Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to run both Spring Messaging and RSocket-RPC simultaneously #26423

Closed
bsideup opened this issue Jan 21, 2021 · 1 comment
Closed
Labels
for: external-project Needs a fix in external project

Comments

@bsideup
Copy link

bsideup commented Jan 21, 2021

As a user of rsocket-rpc-java in Liiklus, I would like to be able to reuse Spring {Framework,Boot}'s RSocket support, and be able to handle rsocket-rpc requests while having some routes (as per RSocket's Routing) defined as Spring Messaging's handlers.

Expectation:

  1. I create an instance of RSocketRPCRouteHandler that rsocket-rpc generated for me
  2. I register it to some registry of RouteHandlers
  3. While handling RSocket requests, Spring's RSocket support delegates to some abstraction that uses registered RouteHandlers to decide which one should handle the request

This all is very similar to the HTTP support & Servlets API, where a Servlet can be added next to Spring Framework's DispatcherServlet and handle a subset of requests.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 21, 2021
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jan 22, 2021

This requires a lower level routing mechanism, so I've created rsocket/rsocket-java#974. When that mechanism becomes available, I expect it to be possible to plug multiple, independent RSocket handlers which by definition should be independent of each other and not be aware of each other. So I'll close this for now and we can create a new one later when it's more obvious what if anything needs to be done here or in Spring Boot more likely where the server is bootstrapped and configured.

@rstoyanchev rstoyanchev added for: external-project Needs a fix in external project and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project Needs a fix in external project
Projects
None yet
Development

No branches or pull requests

3 participants