Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the filter part of a CriteriaQuery from post_filter into the created bool query. #2857

Closed
sothawo opened this issue Feb 24, 2024 · 2 comments · Fixed by #2906
Closed

Move the filter part of a CriteriaQuery from post_filter into the created bool query. #2857

sothawo opened this issue Feb 24, 2024 · 2 comments · Fixed by #2906
Labels
type: enhancement A general enhancement
Milestone
5.3 GA (2024.0.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Feb 24, 2024

No description provided.

@sothawo sothawo added the type: task A general task label Feb 24, 2024
@sothawo sothawo mentioned this issue Feb 24, 2024
Closed
@bernhardkern
Copy link

Hi @sothawo,

thx for creating this task. Can I provide any further information / support to help with this topic? For other participants working on this topic:

Github example with failing test

Anytime we add an Aggregation, the CriteriaGeoQuery as base of NativeQuery the filter only works for the searchHits, but not for the aggregation.

@sothawo sothawo changed the title Check if the filter part of a CriteriaQuery can be moved from post_filter into the craeted bool query Check if the filter part of a CriteriaQuery can be moved from post_filter into the created bool query Apr 26, 2024
@sothawo
Copy link
Collaborator Author

sothawo commented Apr 26, 2024

I don't think there's more information needed about what to do. I just did not yet have the time to look into this.

sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue May 4, 2024
@sothawo
Add the filter parts of a CriteriaQuery to the query, not as post-fil…
7cdb2b5 
…ter.

Closes spring-projects#2857
@sothawo sothawo changed the title Check if the filter part of a CriteriaQuery can be moved from post_filter into the created bool query Move the filter part of a CriteriaQuery from post_filter into the created bool query. May 4, 2024
@sothawo sothawo added type: enhancement A general enhancement and removed type: task A general task labels May 4, 2024
@sothawo sothawo mentioned this issue May 4, 2024
Merged
sothawo added a commit that referenced this issue May 4, 2024
@sothawo
Add the filter parts of a CriteriaQuery to the query, not as post-fil…
dc5bf5a 
…ter.

Original Pull Request #2906
Closes #2857
@sothawo sothawo added this to the 5.3 GA (2024.0.0) milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
5.3 GA (2024.0.0)
2 participants
@sothawo @bernhardkern