Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown for RSockets #25399

Open
dsyer opened this issue Feb 23, 2021 · 3 comments
Open

Graceful shutdown for RSockets #25399

dsyer opened this issue Feb 23, 2021 · 3 comments
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Milestone
General Backlog

Comments

@dsyer
Copy link
Member

dsyer commented Feb 23, 2021 •
edited

Along the lines of WebServer.shutDownGracefully() it would be good to be able to control the shutdown of an RSockets app (client and server). Right now, I think all you can do is ApplicationContext.close() and that leads to potentially cutting off in-flight requests and channels at the knees. See also: rsocket/rsocket-java#988.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 23, 2021
@snicoll
Copy link
Member

snicoll commented Mar 1, 2021

Isn't this blocked by the RSocket issue you referenced?

@dsyer
Copy link
Member Author

dsyer commented Mar 1, 2021

I suppose. TBH I don't know. We'd have to ask @OlegDokuka.

@OlegDokuka
Copy link

@dsyer technically, it is possible to do a workaround on the framework level, however, the workaround will be too wide to support it then. I propose to wait for the RSocket-Java to support it.

@dsyer Is it a critical feature for you?

@bclozel bclozel added the status: blocked An issue that's blocked on an external project change label Mar 2, 2021
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 19, 2022
@wilkinsona wilkinsona added this to the General Backlog milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Projects
None yet
Milestone
General Backlog
Development

No branches or pull requests
6 participants
@bclozel @dsyer @snicoll @wilkinsona @OlegDokuka @spring-projects-issues