Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to configure line separator for RecursiveCollectionLineAggregator #4594

Closed
rsandtner opened this issue May 14, 2024 · 2 comments

Comments

@rsandtner
Copy link

Expected Behavior

The possibility to set the line separator for the RecursiveCollectionLineAggregator exists.

Current Behavior

The line separator is hardcoded using System.getProperty("line.separator")

Context

Batch integration tests are executed on different dev machines using different OS with different line endings (Windows, Mac, Linux).
We use golden files to check the file content and, therefore, are dependent on line endings.

Workaround:

  • set the system property for the specific tests
  • use strings instead of golden files
@rsandtner rsandtner added status: waiting-for-triage Issues that we did not analyse yet type: feature labels May 14, 2024
@fmbenhassine fmbenhassine added in: infrastructure and removed status: waiting-for-triage Issues that we did not analyse yet labels May 21, 2024
@fmbenhassine fmbenhassine added this to the 5.2.0-M1 milestone May 21, 2024
@fmbenhassine
Copy link
Contributor

Thank you for raising this. In fact, the line separator should be configurable in RecursiveCollectionLineAggregator. I will plan that for v5.2.

@rsandtner
Copy link
Author

thx @fmbenhassine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants