Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the Type float/Float in the API #712

Open
ullenboom opened this issue May 11, 2024 · 0 comments
Open

Reconsider the Type float/Float in the API #712

ullenboom opened this issue May 11, 2024 · 0 comments

Comments

@ullenboom
Copy link

A floating-point number with limited precision is commonly used in AI. However, using float or Float as a data type in the API might be impractical, and it could be worth reevaluating this decision.

For instance, your own example in the reference documentation (https://docs.spring.io/spring-ai/reference/api/clients/ollama-chat.html) results in a compiler error, guess why :)

ChatResponse response = chatClient.call(
    new Prompt(
        "Generate the names of 5 famous pirates.",
        OllamaOptions.create()
            .withModel("llama2")
            .withTemperature(0.4)
    ));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant