Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate class name BeanOutputConverter #709

Open
ullenboom opened this issue May 10, 2024 · 3 comments
Open

Reevaluate class name BeanOutputConverter #709

ullenboom opened this issue May 10, 2024 · 3 comments

Comments

@ullenboom
Copy link

ullenboom commented May 10, 2024

BeanOutputConverterworks fine with records too:

record Profile( String nickname, int hornlength ) {}
var outputParser = new BeanOutputConverter<>( Profile.class );
System.out.println( outputParser.getFormat() );

->

Your response should be in JSON format.
Do not include any explanations, only provide a RFC8259 compliant JSON response following this format without deviation.
Do not include markdown code blocks in your response.
Here is the JSON Schema instance your output must adhere to:
```{
  "$schema" : "https://json-schema.org/draft/2020-12/schema",
  "type" : "object",
  "properties" : {
    "hornlength" : {
      "type" : "integer"
    },
    "nickname" : {
      "type" : "string"
    }
  }
}```

Maybe rename the class name.

This reminds me of class DataClassRowMapper extends BeanPropertyRowMapper.

@eddumelendez
Copy link
Contributor

There is a new class OutputParserConverter

@tzolov
Copy link
Collaborator

tzolov commented May 11, 2024

@ullenboom ullenboom changed the title Reevaluate class name BeanOutputParser Reevaluate class name BeanOutputConverter May 13, 2024
@ullenboom
Copy link
Author

I've updated my issue. The naming concern also applies to BeanOutputConverter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants