Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to turn off a route without removing #308

Closed
spencergibb opened this issue May 8, 2018 · 3 comments · May be fixed by #3026
Closed

Add ability to turn off a route without removing #308

spencergibb opened this issue May 8, 2018 · 3 comments · May be fixed by #3026
Labels
wontfix

Comments

@spencergibb
Copy link
Member

Disable a route, maybe via an enabled flag on a route.
@kreativecoder
Copy link

Hello @spencergibb, Have been wanting to contribute to spring cloud projects, and this seems like an issue I can tackle, howbeit I will need a little guidance as this will be my first time contributing to an open source project.

@spencergibb spencergibb mentioned this issue Apr 10, 2019
Closed
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 6, 2023
@usrivastava92
* Add enable parameter
feaaa7a 
Fixes spring-cloudgh-308
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 11, 2023
@usrivastava92
* returned enabled routes only
538097f 
Fixes spring-cloudgh-308
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 11, 2023
@usrivastava92
* removed setup changes
5b3406d 
Fixes spring-cloudgh-308
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 11, 2023
@usrivastava92
* removed setup changes
7310aef 
Fixes spring-cloudgh-308
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 11, 2023
@usrivastava92
* added integration and unit test
306363a 
Fixes spring-cloudgh-308
usrivastava92 added a commit to usrivastava92/spring-cloud-gateway that referenced this issue Aug 11, 2023
@usrivastava92
* added integration and unit test
a17deb8 
Fixes spring-cloudgh-308
@usrivastava92 usrivastava92 mentioned this issue Aug 11, 2023
Open
@usrivastava92
Copy link

hi @spencergibb I have raised a PR for this enhancement. As this is my first contribution, please let me know if there is anything else that I need to do as a part of process. 🙂

@spencergibb
Copy link
Member Author

Closing in favor of #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes gh-308: ability to turn off a route without removing usrivastava92/spring-cloud-gateway
3 participants
@spencergibb @kreativecoder @usrivastava92