Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Introduce RequestContext to easily pass new parameters to downstream methods #2408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

opeco17
Copy link

@opeco17 opeco17 commented Apr 22, 2024

Fixes #2407

@opeco17 opeco17 changed the title Refactoring/introduce request context [Refactoring] Introduce RequestContext to easily pass new parameters to downstream methods Apr 22, 2024
@opeco17
Copy link
Author

opeco17 commented Apr 28, 2024

Hi, @ryanjbaxter @spencergibb

Could you please review this PR?
Thank you!

@ryanjbaxter
Copy link
Contributor

I think this is the right idea for where we want to go.

The issue is as is it could only go in a major release because of the breaking API changes. That is fine but after talking about it some more with the team we should really be deprecating the existing public APIs in the 2024 release (which will be a minor) and then remove them in 2025 release (which will likely be our next major). Its more of a process thing than anything else, but this way we could also get #2402 in the 2024 release as well.

@opeco17
Copy link
Author

opeco17 commented Apr 29, 2024

@ryanjbaxter

Thank you for sharing.
It would be nice if #2402 becomes available in 2024 release.

May I know the next action that I should take?
Is some revise to this PR necessary?

@ryanjbaxter
Copy link
Contributor

Yes we would need to keep the existing public APIs intact and unchanged and mark them all as @Deprecated then introduce the new ones (as you already have in this PR) which use the RequestContext object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactoring] Introduce RequestContext to easily pass new parameters to downstream methods
3 participants