Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

QueueMessageChannel.receive() implementation doesn't align with PollableChannel 's definition #770

Open
jorgenota opened this issue Apr 3, 2021 · 0 comments
Open

QueueMessageChannel.receive() implementation doesn't align with PollableChannel 's definition #770

jorgenota opened this issue Apr 3, 2021 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@jorgenota
Copy link

Type: Bug

Component:

SQS

Describe the bug

  • According to javadoc of PollableChannel, MessageChannel.INDEFINITE_TIMEOUT should be used to represent indefinite timeout (instead of 0).
  • The timeout parameter of PollableChannel.receive() method represents the timeout in milliseconds (so it should be transformed into seconds when building the ReceiveMessageRequest).

This PR betters shows the suggested fix: #769
@github-actions github-actions bot added type: bug A general bug status: waiting-for-triage An issue we've not yet triaged labels Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgenota