respond_to fix should be backported into 4.4.x

[mrbrdo]

This fix 960003e
Should be put in a stable version. 4.4.0 ("stable" release) is broken due to this.

[Kulgar]

Just in case you need it, I created a fork with a tag v4.4.1 https://github.com/Kulgar/spree_legacy_frontend/tags which backports the fix + the migration from turbolinks to turbo.

Here are the details about which commits I picked and which I skipped:

--- kept

commit 31725b84516cfb66236887ef9d24d67a939748f1 (origin/main, origin/HEAD, main)
Author: Damian Legawiec <damian@getvendo.com>
Date:   Mon Mar 28 13:33:52 2022 +0200

    Fixed registration form with turbo

commit 384ed3753fc75de1f5f73035e296bf57262ba345
Author: Damian Legawiec <damian@getvendo.com>
Date:   Sun Mar 27 18:31:45 2022 +0200

    Fixed login with turbo


commit 960003ec2bf203087586dabe04343c703a466345
Author: Damian Legawiec <damian@getvendo.com>
Date:   Sun Mar 27 16:27:25 2022 +0200

    Fixed `repond_to` -> `respond_to?`

commit f14ba405775d05840a11e461357fa598484de27d
Author: Damian Legawiec <damian@getvendo.com>
Date:   Mon Mar 21 23:32:13 2022 +0100

    Fixed JS errors

commit eb024abc41053aeb74a93e93dcb86e5b304c6478
Author: Damian Legawiec <damian@getvendo.com>
Date:   Fri Mar 18 14:13:47 2022 +0100

    Fixed cart form variant choosed with UUIDs (#10)

commit 666b13e2ca1cded44d9780b108c56910aa48831d
Author: Damian Legawiec <damian@getvendo.com>
Date:   Thu Mar 17 21:21:27 2022 +0100

    Fixed JS to work with UUIDs (#9)
    
    * Fixed JS to work with UUIDs
    
    * fix

commit d630e1e566d562c89c383b083cdf5ad98f016e84
Author: Damian Legawiec <damian@getvendo.com>
Date:   Thu Mar 17 14:32:31 2022 +0100

    Migrate from Turbolinks to Turbo (#7)

commit 42ef15080c720df351474d9a77c702fc1c94f3fc
Author: Damian Legawiec <damian@getvendo.com>
Date:   Wed Mar 16 20:13:12 2022 +0100

    Fix compatibility with Spree v5

--- skipped

commit b58e973fa44fee22aab5bfb0ae11c79cfad3571e
Author: Damian Legawiec <damian@getvendo.com>
Date:   Sun Mar 27 18:00:16 2022 +0200

    Update README.md

commit 04af4a20659891db90d03f05a8cb45ae007ada38
Author: Damian Legawiec <damian@getvendo.com>
Date:   Thu Mar 17 17:57:05 2022 +0100

    Support CDN introduced in Spree v4.5 (#8)
    
    * Support CDN introduced in Spree v4.5
        * fix


commit e8112c6b93db57e66e73bff2d6cb564e1148a9c6
Merge: ec17bb9c54 c7ddd16336
Author: Damian Legawiec <damian@getvendo.com>
Date:   Wed Mar 16 21:59:09 2022 +0100

    Merge pull request #6 from spree/feature/rails-7
    
    Fix compatibility with Rails 7

commit c7ddd163365cf1a316d9232f7655afcd42017447
Author: Damian Legawiec <damian@getvendo.com>
Date:   Wed Mar 16 21:44:44 2022 +0100

    Fixed specs

commit 32fbd85cae88261667a62849327ed988f4b0f4a7
Author: Damian Legawiec <damian@getvendo.com>
Date:   Wed Mar 16 20:27:42 2022 +0100

    Fixed CMS for Rails 7
    
    Ref: https://github.com/spree/spree/commit/e708e89955bce10588958b08102df781f9da4fab


commit 488c1bb6ad38da3ffbda6d4de16774e2c5a987e0
Author: Damian Legawiec <damian@getvendo.com>
Date:   Wed Mar 16 15:36:06 2022 +0100

    Fix compatibility with Rails 7

[mrbrdo]

Personally I don't, because I'm still running 4.3.1 until there is a stable and working version of 4.4+ of both spree and the legacy frontend, which unfortunately there isn't. I hope the Spree team will start taking PRs more seriously because I am left demotivated and saddened by the current situation. I am running with patches for spree_frontend, spree_backend, spree_core, spree_auth_devise and spree_globalize and at the moment it seems to be running smoothly now. Waiting for the fixes to be merged then I will try 4.4+.