Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipment total manager (JS) doesn't work correctly with tax #11

Open
mrbrdo opened this issue Mar 21, 2022 · 0 comments
Open

Shipment total manager (JS) doesn't work correctly with tax #11

mrbrdo opened this issue Mar 21, 2022 · 0 comments

Comments

@mrbrdo
Copy link
Contributor

mrbrdo commented Mar 21, 2022

When you are using tax included in price setting, the ShippingTotalManager will subtract tax difference between methods twice, causing wrong calculation in the checkout shipping step.
The problematic line is
var newOrderTotal = orderTotal + this.totalShipmentAmount(newShipmentTotal, oldShipmentTotal) + (newTaxTotal - oldTaxTotal)
If the last part is removed, it works correctly when Store prices are set to include tax (as is usual in EU).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant