Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkout/_payment_confirm.html.erb does not honor the mounting path of Spree Engine #392

Open
nflorentin opened this issue Jul 9, 2021 · 0 comments · May be fixed by #407
Open

checkout/_payment_confirm.html.erb does not honor the mounting path of Spree Engine #392

nflorentin opened this issue Jul 9, 2021 · 0 comments · May be fixed by #407

Comments

@nflorentin
Copy link

Hi,

The following line in checkout/_payment_confirm.html.erb has an hardcoded url which does not honor the mounting path of Spree Engine. Therefore, the payment is failing if mounting path is different than '/'.

$.post("/api/v2/storefront/intents/handle_response", { response: response, order_token: "<%= @order.token %>" }).done(function (result) {

I guess this is a bug because the other spree gems take into account the mouting path.

To temporarily fix it, I copied the entire file and update the url by hand.

Thanks for your work.
dylanfisher added a commit to dylanfisher/spree_gateway that referenced this issue Jul 18, 2022
@dylanfisher
If Spree.pathFor is defined, use this to generate Stripe intent URL
be6fe81 
Without this change, the mount path of the Spree engine isn't taken
into account, and this hard-coded URL results in a 404.

Fixes spree#392
@dylanfisher dylanfisher linked a pull request Jul 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If Spree.pathFor is defined, use this to generate Stripe intent URL dylanfisher/spree_gateway
1 participant
@nflorentin