Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing weights of products/variants doesn't bust cache #186

Open
brchristian opened this issue May 12, 2014 · 0 comments
Open

changing weights of products/variants doesn't bust cache #186

brchristian opened this issue May 12, 2014 · 0 comments

Comments

@brchristian
Copy link
Contributor

I notice that the retrieve_rates_from_cache method uses a cache key that looks at the Order, the Destination, etc...

However, it does not include the Products or Variants of the Order into the MD5. So if the weight of a product or variant is changed on the backend, users might see obsolete cached rates.

I'd suggest we throw all of the included products and variants into the hash, so that if any of them are updated, we expire this shipping rate cache, just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant