Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance profile seems to accept name OR arn (but this isn't clear) #134

Open
ghostsquad opened this issue Dec 10, 2020 · 0 comments
Open
Assignees
Labels
kind/feature Categorizes an issue or PR as related to a new feature or request.

Comments

@ghostsquad
Copy link

Terraform Version

Terraform v0.13.5
+ provider registry.terraform.io/hashicorp/aws v3.14.1
+ provider registry.terraform.io/hashicorp/kubernetes v1.13.3
+ provider registry.terraform.io/hashicorp/local v2.0.0
+ provider registry.terraform.io/hashicorp/null v3.0.0
+ provider registry.terraform.io/hashicorp/random v3.0.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/terraform-providers/spotinst v1.27.0

Description

regarding: https://registry.terraform.io/providers/spotinst/spotinst/latest/docs/resources/ocean_aws

the ocean_aws resource seems iam_instance_profile accepts either an ARN or a Name but this isn't explained in the documentation. I found this out because I was comparing some configuration differences between clusters we have and how they were created via terraform, and I saw in the SpotInst UI -> View Configuration the following:

cluster 1

   "iamInstanceProfile": {
     "name": "<CLUSTER_NAME>20201209214601735300000002"
   },

cluster 2

"iamInstanceProfile": {
"arn": "arn:aws:iam:::instance-profile/<CLUSTER_NAME>20201021021723070600000004"
},


This is a request to improve the documentation AND/OR change the meaning of the parameter and include multiple parameters to make it clear what you expect to see as input.

### Community Note

* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to help the community and maintainers prioritize this request.
* If you are interested in working on this issue or have submitted a pull request, please leave a comment.

<!--- Thank you for keeping this note for the community --->
@ghostsquad ghostsquad added the kind/feature Categorizes an issue or PR as related to a new feature or request. label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as related to a new feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants