Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp wrappers are using default namespace #52

Open
alexander-riss opened this issue Feb 26, 2024 · 2 comments
Open

cpp wrappers are using default namespace #52

alexander-riss opened this issue Feb 26, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alexander-riss
Copy link

if one wanted to only use the cpp part of voyager, it would be a problem as some of the header files are not using a voyager specific namespace like e.g. spotify::voyager to avoid name collitions if used in a broader context and are instead in the default namespace.

@markkohdev markkohdev added enhancement New feature or request good first issue Good for newcomers labels Mar 20, 2024
@markkohdev
Copy link
Contributor

markkohdev commented Mar 22, 2024

Hey @alexander-riss, thanks for pointing this out! We originally didn't really intend for voyager to be used as a standalone C++ library because we want to ensure that we can change the underlying implementation easily. But there's no reason we shouldn't allow for c++ lib usage if people are willing to build it from source.

We've discussed that we will make this change, but with the caveat that we don't guarantee compatibility of the C++ interface between versions.

@alexander-riss
Copy link
Author

That sounds great! this will enable a lot of new on-device workflows!

@markkohdev markkohdev mentioned this issue Apr 1, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants