Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PEP 517/518 (pyproject.toml build-system) #3222

Open
starhel opened this issue Jan 30, 2023 · 0 comments
Open

Support for PEP 517/518 (pyproject.toml build-system) #3222

starhel opened this issue Jan 30, 2023 · 0 comments

Comments

@starhel
Copy link
Contributor

starhel commented Jan 30, 2023

PEP 517/518 (as well as their successors) are widely adapted to the python ecosystem and have become standard in how Python distribution builds are declared and executed1. Because of the last pip deprecation (pypa/pip#8559) I'm opening this issue.

I've made some tests and luigi could be easily refactored to setup.cfg + pyproject.toml2. Unfortunately, there are some issues to solve:

  • Moving all metadata to setup.cfg requires using importlib.metadata (or its backport) to generate luigi.__meta__. Backport is available from python 3.6, so I was forced to drop python 3.5 support (EOL Sep 2020).
  • I've never uploaded docs to readthedocs.io, so I don't know if the READTHEDOCS environment param is still used and necessary (as tox -e dev does not use it to locally build docs).

If you are ok with dropping support for pythons older than 3.6 and removing READTHEDOCS env param, I can prepare PR with all necessary changes. When all changes will be done, deploying new versions should also enforce building wheel distribution (it's a single step using build). If you want I could also prepare a GitHub Action workflow to publish packages to PyPI and GH releases based on pushing tags to the repository.

  1. More about avoiding setup.py: https://setuptools.pypa.io/en/latest/userguide/quickstart.html#setuppy-discouraged
  2. I'm aware that setuptools supports now also pyproject.toml configuration, but many features are still in the beta stage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant