Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

## Codestyle: enforce consistent statement-spacing and indentation (See issue #720) #729

Open
sming opened this issue Nov 28, 2020 · 0 comments
Labels
codebase quality high level issues pertaining to improvements / problems with the codebase's quality

Comments

@sming
Copy link
Contributor

sming commented Nov 28, 2020

Codestyle: enforce consistent statement-spacing and indentation (See issue #720)

NOTE: * This is the issue where we need to uncomment the commented-out modules (Indentation, EmptyLineSeparator) and fix all the compilation errors. This will take a fair bit of manual effort!

Use Case Resolved: avoidable debate during code review that wastes time

  • I am a heroic dev
  • who wants to know precisely what the squad considers legitimate code formatting
  • so that when it comes to code review, there is no need for back-and-forth debate as to our coding style

Design & Implementation Notes

  • DONE add commented-out checkstyle config for bad indentation
  • TODO uncomment the commented-out modules (Indentation, EmptyLineSeparator) and fix all the compilation errors. This will take a fair bit of manual effort!
@sming sming added the codebase quality high level issues pertaining to improvements / problems with the codebase's quality label Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
codebase quality high level issues pertaining to improvements / problems with the codebase's quality
Projects
Observability Kanban
  
Awaiting triage
Development

No branches or pull requests

1 participant