Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Add Distribution Support to Heroic Consumer #695

Open
ao2017 opened this issue Sep 15, 2020 · 0 comments
Open

Add Distribution Support to Heroic Consumer #695

ao2017 opened this issue Sep 15, 2020 · 0 comments

Comments

@ao2017
Copy link
Contributor

ao2017 commented Sep 15, 2020

Heroic histogram data is currently computed locally.
It is practically impossible to aggregate percentile.
We are adding distribution to heroic to address that issue. Applications downstream will create data sketches that can be merged to compute percentile on the entire data distribution.
To support this approach, we changed the format of the metric.
Heroic consumers should be able to handle both the old and the new metrics.
We are creating a new version of Spotify100 serializer. This task will implement the logic to handle spotify100 new version metrics.
Reference
Current Format
Spotify100 version SCHEMA_VERSION = "1.1.0"
@DaTa
public static class Spotify100Metric {
private final String version = SCHEMA_VERSION;
private final String key;
private final Long time;
private final Map<String, String> attributes;
private final Map<String, String> resource;
private final double value;
}
Expected Format
Spotify100 version SCHEMA_VERSION = "1.1.2" (actual TBD)
@DaTa
public static class Spotify100Metric {
private final String version = SCHEMA_VERSION;
private final String key;
private final Long time;
private final Map<String, String> attributes;
private final Map<String, String> resource;
private final Value value;
}

Code Pointer:

private AsyncFuture<Void> handleVersion1(final JsonNode tree)

@project-bot project-bot bot added this to Inbox in Observability Kanban Sep 15, 2020
@ao2017 ao2017 self-assigned this Sep 15, 2020
@project-bot project-bot bot moved this from Inbox to In progress in Observability Kanban Sep 15, 2020
@sming sming moved this from In progress to To do in Observability Kanban Sep 16, 2020
@adsail adsail moved this from To do to In progress in Observability Kanban Sep 25, 2020
@samfadrigalan samfadrigalan moved this from In progress to Ready to deploy in Observability Kanban Oct 5, 2020
@adsail adsail moved this from Ready to deploy to Done in Observability Kanban Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

1 participant