Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tool list into Chart initialization #82

Open
birdsarah opened this issue Jun 13, 2019 · 0 comments
Open

Pass tool list into Chart initialization #82

birdsarah opened this issue Jun 13, 2019 · 0 comments

Comments

@birdsarah
Copy link

birdsarah commented Jun 13, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

type: bug

type: feature

I'd like to be able to pass the tools argument into Chart e.g. p = chartify.Chart(x_axis_type='categorical', blank_labels=True, tools='wheel_zoom, save')

Anything that's accepted for bokeh's figure would be acceptable and would get passed in here: https://github.com/spotify/chartify/blob/master/chartify/_core/chart.py#L175

With default as tools='save' so this would be a non-breaking API change.

(I'm a bokeh dev, so I'm very familiar with writing bokeh code and so naturally want to do tweak things. I understand that in a wrapper library like this the whole point is to provide an abstraction. I have never designed an abstracted API like this, so I understand if this kind of feature request is not the direction you want to take the API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant