Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text_type in load_wbb_pbp has MadeFreeThrow for both made and missed free throws #18

Open
sambruchhaus opened this issue Jan 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@sambruchhaus
Copy link

Describe the bug
The column text_type in the resulting data from load_wbb_pbp() has "MadeFreeThrow" for both made and missed free throws

To Reproduce
Steps to reproduce the behavior:

  1. Call load_wbb_pbp()
  2. Filter by text to retrieve missed free throws
  3. text for "[Name] missed Free Throw" has "MadeFreeThrow" for the value of text_type

Expected behavior
The text should be either "FreeThrow" or "MissedFreeThrow" for more intuitive filtering.

Screenshots
If applicable, add screenshots to help explain your problem.

Screen Shot 2022-01-11 at 6 34 16 PM

Version:
1.2.1

Additional context
Encountered while trying to calculate Athletes Unlimited Scoring from Play-by-Play

@saiemgilani
Copy link
Collaborator

While not something I mess with to create the type_text field, nonetheless disconcerting. I will try to validate more as the season goes along (more like off-season) , but if you have like code to validate the types, I'd welcome a PR

@armstjc armstjc added the enhancement New feature or request label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants