Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect/Mismatched Game IDs in NBA API functions #135

Open
mattmattoni opened this issue Dec 6, 2023 · 1 comment
Open

Incorrect/Mismatched Game IDs in NBA API functions #135

mattmattoni opened this issue Dec 6, 2023 · 1 comment

Comments

@mattmattoni
Copy link

Awesome package. However, there is an issue that there is a mismatch between game IDs across functions.

For example, if I use the load_nba_team_box(2024) function, the 12/4/2023 game between the Pelicans and Kings has game ID 401607492. However, this Game ID is not a valid input to any other arguments using the NBA API. Additionally, it does not follow the NBA API Game ID format, and does not even have the correct number of digits.
Any NBA API function will give the following error:

nba_boxscoreadvancedv2(401607492)
Error in nba_boxscoreadvancedv2(401607492) : object 'df_list' not found

Is there an error in game ID acquisition? If not, is there a way to easily find Game IDs that match the NBA's API? Or, is there some way to convert between IDs?

@saiemgilani
Copy link
Collaborator

Yeah, the loading functions currently use ESPN game_ids and to find the NBA API's game_id's, use the nba_schedule() function, which uses the NBA API as its data source. See the getting started vignette if you're confused about which functions correspond to others. I suppose the load functions aren't perfectly clearly documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants