Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add configurable timeout delays exiting failed atomic red team tests #215

Closed
jzsplunk opened this issue Feb 4, 2020 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jzsplunk
Copy link
Contributor

jzsplunk commented Feb 4, 2020

One of the atomic red team tests seems to take upwards of 30 minutes to terminate in my testing. Not necessarily an issue but just want to make a feature request on maybe being able to configure in attack.conf the length of time we wait until we time out the state of the test (if thats even possible). Timestamps show beginning and end of execution of T1071 in my local testing:

Start: 2020-02-04 14:49:35
Finish: 2020-02-04 15:21:35

python attack_range.py -m terraform -a simulate -st T1071 -t attack-range-windows-domain-controller

`2020-02-04 14:49:35,618 - INFO - attack_range - INIT - attack_range v1

PLAY [all] *********************************************************************

TASK [atomic_red_team : Check we have installed Atomic Red Team] ***************
ok: [44.228.118.166]

TASK [atomic_red_team : Copy Atomic Red Team PS module] ************************
changed: [44.228.118.166]

TASK [atomic_red_team : Install Atomic Red Team PS Module] *********************
changed: [44.228.118.166]

TASK [atomic_red_team : Clean up before execution C:\Windows\Temp] *************
changed: [44.228.118.166]

TASK [atomic_red_team : Recreate C:\Windows\Temp before execution] *************
changed: [44.228.118.166]

TASK [atomic_red_team : set_fact] **********************************************
ok: [44.228.118.166]

TASK [atomic_red_team : Run Techniques] ****************************************
ok: [44.228.118.166] => {
"techniques": [
"T1071"
]
}

TASK [atomic_red_team : Make Atomic Red Team Execution Directory] **************
changed: [44.228.118.166]

TASK [atomic_red_team : Run all Atomic Red Team Tests] *************************
skipping: [44.228.118.166]

TASK [atomic_red_team : Run specified Atomic Red Team Technique] ***************
changed: [44.228.118.166] => (item=T1071)

TASK [atomic_red_team : Check Execution Log File] ******************************
ok: [44.228.118.166]

TASK [atomic_red_team : Save Log File] *****************************************
changed: [44.228.118.166]

TASK [atomic_red_team : Clean up processes] ************************************
changed: [44.228.118.166]

TASK [atomic_red_team : Clean up after execution] ******************************
changed: [44.228.118.166]

PLAY RECAP *********************************************************************
44.228.118.166 : ok=13 changed=9 unreachable=0 failed=0 skipped=1 rescued=0 ignored=0

2020-02-04 15:21:35,465 - INFO - attack_range - successfully executed technique ID T1071 against target: attack-range-windows-domain-controller`

@josehelps
Copy link
Contributor

@jzsplunk chatted a bit with the atomic red team group and it seems that this might be due to the fact that we do not configure out the box the technique and set a valid domain name instead of example.com: https://github.com/redcanaryco/atomic-red-team/blob/master/atomics/T1071/T1071.yaml#L79 and thus you have 1000 request time out. This is likely what is delaying that test. For now we would have to figure out a way to customize these tests since it is not something we do.

@josehelps josehelps added the enhancement New feature or request label Feb 6, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 7, 2020
@dlamspl
Copy link

dlamspl commented Apr 16, 2020

The new version will have builtin feature for timeouts and other cool stuff.
https://redcanary.com/blog/invoke-atomicredteam-leaves-the-nest/

@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2020
@josehelps
Copy link
Contributor

the following technique currently does not work python attack_range.py -m terraform -a simulate -st T1086 -t attack-range-windows-domain-controller just hangs during execution.

@josehelps josehelps added the bug Something isn't working label Jun 4, 2020
@jzsplunk
Copy link
Contributor Author

This issue is not present in the latest develop branch after merging changes @P4T12ICK worked on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants