Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: generated nav configuration should not default to configuration view #1041

Open
pmeyerson opened this issue Feb 1, 2024 · 1 comment
Open

BUG: generated nav configuration should not default to configuration view #1041

pmeyerson opened this issue Feb 1, 2024 · 1 comment
Assignees
@artemrys
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pmeyerson
Copy link

Description

It seems that the default view in ucc-generated nav/default.xml is set to the configuration page, which is an issue if this page requires admin privileges.
Better to default to the search view.

generated /default/data/ui/nav/default.xml:

<?xml version="1.0" ?>
<nav>
    <view default="true" name="configuration"/>
    <view name="search"/>
</nav>

NOTE: I have latest pip 5.37.0 installed fresh, but the output log shows 5.28.4 for some reason.

What ucc-gen version are you using?

5.37.0

Additional System Info

No response
@pmeyerson pmeyerson added the bug Something isn't working label Feb 1, 2024
@artemrys
Copy link
Member

@pmeyerson I think we definitely can provide such an option in the globalConfig file.

Changing the default - I think it will be too big of a change.

@artemrys artemrys added the good first issue Good for newcomers label May 15, 2024
@artemrys artemrys self-assigned this May 15, 2024
@artemrys artemrys mentioned this issue May 15, 2024
Merged
4 tasks
artemrys added a commit that referenced this issue Jun 3, 2024
@artemrys
feat: allow developers to choose the default view (#1197)
21610e2 
**Issue number:** #1041

## Summary

### Changes

> Please provide a summary of what's being changed

Configuration page require admin privileges and if a Splunk user is not
an admin - configuration page will show an error which is confusing.
This PR allows to set a default page to `search` so there will be no
error shown when a Splunk user opens add-on for the first time.

This PR enables TA developers to choose the default view, one of four:
`inputs`, `configuration`, `dashboard` and `search`.

### User experience

> Please describe what the user experience looks like before and after
this change

Nothing changes for the existing customers. For customers who decide to
use `search` view as a default one - they need to update their
globalConfig file, specifically set `meta.defaultView` to `search` and
rebuild an add-on.

## Checklist

If your change doesn't seem to apply, please leave them unchecked.

* [x] I have performed a self-review of this change
* [x] Changes have been tested
* [ ] Changes are documented
* [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemrys artemrys

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artemrys @pmeyerson