Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "owers" to "beneficiaries"? #807

Open
zorun opened this issue Jul 17, 2021 · 3 comments
Open

Rename "owers" to "beneficiaries"? #807

zorun opened this issue Jul 17, 2021 · 3 comments

Comments

@zorun
Copy link
Collaborator

zorun commented Jul 17, 2021

I find "owers" really hard to understand, and it does not seem very common. I also have trouble translating it to French, the current translation is "débiteur" which is very technical.

Fortunately, it's not used much in the user interface.

What about renaming it to "beneficiaries"? It's the people that benefit from a bill, which means they need to participate financially.

@Glandos
Copy link
Member

Glandos commented Jul 17, 2021

It's deeply rooted into the project: b3db905#diff-033b73e4d04258f5db8307e1f3befc5033cd554ffc801b4d4bb347a8dbbb5715R52 (aka: it's the initial commit).

Do you planned to rename just the I18N parts? Or also the whole code?

@zorun
Copy link
Collaborator Author

zorun commented Jul 17, 2021

Hmm, right, good question, there are three kind of places where it's used:

  • UI: I checked again and "owers" is only used in the history log
  • code: changing it should not be very hard, but it has limited usefulness
  • API fields (such as JSON export): changing that would be a big breaking change

So, it does not seem to be a big UI problem for "normal" users (i.e. not looking at history and not using the API). I was basically annoyed by it when translating the history page.

I propose to leave this open in case somebody else has an opinion, but I'm no longer convinced it's worth changing.

@almet
Copy link
Member

almet commented Oct 17, 2021

I agree this is a bad naming : beneficiaries is better.

We could try changing this in the project and keep it in the API for backwards compatibility? I'm mainly concerned about breaking the API because we have clients out in the wild using it as-is.

I'm also okay with letting it as-is, and just changing this in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants