Changing any settings is prevented when project has existing currency

[Turtle6665]

When a project as a default currency different from "XXX", changing the project settings will not be possible. An error is raised with the message : "Cannot change project currency because currency conversion is broken". The fact is that even if we don't want to change the currency, the message still shows up (same for the API).

This comes from this if statement :

ihatemoney/ihatemoney/forms.py

Lines 196 to 204 in 2bb5350

	if (
	project is not None
	and field.data != CurrencyConverter.no_currency
	and project.has_bills()
	):
	msg = _(
	"Cannot change project currency because currency conversion is broken"
	)
	raise ValidationError(msg)

For me, a better if statement could be (although I didn't test it):

if ( 
     project is not None 
     and field.data != project.default_currency
     and project.has_bills() 
 ):

I know this was a hot fix waiting for improvement with the #1232 but checking for the current project default currency makes more sens considering the error message. This bug is annoying as to change the other settings, we have to set the currency to "no currency" as it's the only condition that doesn't raise this error.

[almet]

Thanks for the heads up, don't hesitate to provide a fix for this, I'll happily review and merge it :-)

[zorun]

Good catch with this bug, thanks for noticing and fixing it!