Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviors while directly visit project URLs #1284

Open
nevercodecorrect opened this issue Jan 3, 2024 · 3 comments
Open

Different behaviors while directly visit project URLs #1284

nevercodecorrect opened this issue Jan 3, 2024 · 3 comments

Comments

@nevercodecorrect
Copy link

Hello,
An attacker could know what are the projects exist by simply brute-force checking localhost:8080/testproject. If the returned page is authenticator then he knows the project exist as if the project does not exist, the returned page will be create project page. It also applies to the user/bill index. The returned page are different and the index is easy to guess.
All those trials does need any login/priveledge at all.

@almet
Copy link
Member

almet commented Jan 3, 2024

You're correct, thanks for bringing this up. I believe it's a tradeoff we're doing right now, to ease the life of the users.

Some more context:

  • the id of the project is not secret, and is not shared with other services, so for instance a leak of a database wouldn't be usable with other leaked databases (like we see for usernames/emails)

Mitigations:

  • We have a protection in place for logins, but only used for /admin, so I wonder if we should also protect other resources, and if that would be enough to mitigate this.
  • Always present the authenticator page, even when the project doesn't exist.
  • Never present the authenticator page, even when the project exists, and always redirect to the front page.

What do you think?

@almet
Copy link
Member

almet commented Apr 28, 2024

We want to display the authentication page in all cases, and ideally merge the project creation form with the one from the homepage.

@nevercodecorrect
Copy link
Author

Sorry for the late reply, that would be better in term of security,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants