{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19834314,"defaultBranch":"master","name":"orca","ownerLogin":"spinnaker","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-05-15T20:33:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7634182?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714473330.0","currentOid":""},"activityList":{"items":[{"before":"bc76db00f3996ce21cde44b0c46af6cb0cae77fb","after":"88114eb396d2b9454e7e8d472417b0e94b2c403b","ref":"refs/heads/master","pushedAt":"2024-05-01T16:01:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"refactor(retrofit): Dismantle RetrofitExceptionHandler (#4716)\n\n* refactor(retrofit): Dismantle RetrofitExceptionHandler\n\nAs the final step towards cleaning up RetrofitError and to incorporate the use of retrofit 2.x, this commit aims at dismantling RetrofitExceptionHandler.\n\nClass: https://github.com/spinnaker/orca/blob/a1b32d7398eb9b1ff610d7f3afd980b51f6cf7b1/orca-retrofit/src/main/java/com/netflix/spinnaker/orca/retrofit/exceptions/SpinnakerServerExceptionHandler.java has already taken place as the replacement for RetrofitExceptionHandler as part of migration process. This class is used in many places across ORCA to handle the upcoming changes of retrofit 2.x.\n\nSince there are no relevant usage found for RetrofitExceptionHandler, its dismantled.\n\n* chore(retrofit): clean up comments related to RetrofitExceptionHandler\n\nsince it no longer exists.\n\n---------\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>\nCo-authored-by: David Byron <dbyron@salesforce.com>","shortMessageHtmlLink":"refactor(retrofit): Dismantle RetrofitExceptionHandler (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2269668889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4716\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4716/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4716\">#4716</a>)"}},{"before":null,"after":"afd22cede12e683863a3d0965dd7af638e439e61","ref":"refs/heads/mergify/bp/release-1.31.x/pr-4682","pushedAt":"2024-04-30T10:35:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted (#4682)\n\nCo-authored-by: ysaxena <ysaxena@expediagroup.com>\n(cherry picked from commit 613427f41bb16461a7ee8bb0f31212b438d75458)","shortMessageHtmlLink":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…"}},{"before":null,"after":"29ff0532b677a0176b87374cc8961fbe6dbea7a6","ref":"refs/heads/mergify/bp/release-1.32.x/pr-4682","pushedAt":"2024-04-30T10:34:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted (#4682)\n\nCo-authored-by: ysaxena <ysaxena@expediagroup.com>\n(cherry picked from commit 613427f41bb16461a7ee8bb0f31212b438d75458)","shortMessageHtmlLink":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…"}},{"before":null,"after":"a01eebe57d9b7dc71959356f40870418917ff01e","ref":"refs/heads/mergify/bp/release-1.33.x/pr-4682","pushedAt":"2024-04-30T10:34:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted (#4682)\n\nCo-authored-by: ysaxena <ysaxena@expediagroup.com>\n(cherry picked from commit 613427f41bb16461a7ee8bb0f31212b438d75458)","shortMessageHtmlLink":"fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi…"}},{"before":null,"after":"90a383264fd3fdba7f6a0f487366cee9e744bc73","ref":"refs/heads/mergify/bp/release-1.34.x/pr-4682","pushedAt":"2024-04-30T10:34:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump fiatVersion (#4704)\n\nCo-authored-by: root <root@28ff04fd44ba>","shortMessageHtmlLink":"chore(dependencies): Autobump fiatVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2246971074\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4704\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4704/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4704\">#4704</a>)"}},{"before":"a1b32d7398eb9b1ff610d7f3afd980b51f6cf7b1","after":"bc76db00f3996ce21cde44b0c46af6cb0cae77fb","ref":"refs/heads/master","pushedAt":"2024-04-29T19:19:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(test/clouddriver): Mock http error using SpinnakerHttpException in WaitForCloudFormationCompletionTaskSpec (#4717)\n\nWith the introduction of the commit: 84a7106c512ceada65d7799f527a956262d964d5 , the expected behaviour of all OortService APIs is to throw SpinnakerHttpException when any http error has occurred.\n\nHere in this test the response of the API : https://github.com/spinnaker/orca/blob/a1b32d7398eb9b1ff610d7f3afd980b51f6cf7b1/orca-clouddriver/src/main/java/com/netflix/spinnaker/orca/clouddriver/OortService.java#L182 is mocked up with RetrofitError which makes the test irrelvant.\n\nWrapping the RetrofitError in SpinnakerHttpException to make it in compliance with the retrofit configuration.\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"fix(test/clouddriver): Mock http error using SpinnakerHttpException i…"}},{"before":"102a9d380e862d98a5f596f4537d80eaa819888d","after":"a1b32d7398eb9b1ff610d7f3afd980b51f6cf7b1","ref":"refs/heads/master","pushedAt":"2024-04-29T16:29:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"refactor(retrofit): Cleanup unused RetrofitError occurrences (#4712)\n\nAs part of the foundational work paving the way towards migrating to retrofit 2.x, this commit aims at cleaning up unused occurrences of RetrofitError throughout ORCA service.\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"refactor(retrofit): Cleanup unused RetrofitError occurrences (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2265531981\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4712\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4712/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4712\">#4712</a>)"}},{"before":"4fe8a71b84e17f4a6d739b3eac1fc58f6400635f","after":"102a9d380e862d98a5f596f4537d80eaa819888d","ref":"refs/heads/master","pushedAt":"2024-04-28T03:24:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump korkVersion (#4715)\n\nCo-authored-by: root <root@8b2740453d3d>","shortMessageHtmlLink":"chore(dependencies): Autobump korkVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2267313160\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4715\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4715/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4715\">#4715</a>)"}},{"before":"acbd6e1cd41173bd8a9f96acd6eeefc0a2b06ba3","after":"4fe8a71b84e17f4a6d739b3eac1fc58f6400635f","ref":"refs/heads/master","pushedAt":"2024-04-27T02:30:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump fiatVersion (#4714)\n\nCo-authored-by: root <root@cfe88d4b31d9>","shortMessageHtmlLink":"chore(dependencies): Autobump fiatVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2266715793\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4714\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4714/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4714\">#4714</a>)"}},{"before":"c235cf3b6fa4064678f66682723741898cfb2641","after":"acbd6e1cd41173bd8a9f96acd6eeefc0a2b06ba3","ref":"refs/heads/master","pushedAt":"2024-04-27T00:49:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump korkVersion (#4713)\n\nCo-authored-by: root <root@8b70676aa6c3>","shortMessageHtmlLink":"chore(dependencies): Autobump korkVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2266653368\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4713\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4713/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4713\">#4713</a>)"}},{"before":"d2f50242637207491ba9fdcc40eaf02c3255c447","after":"c235cf3b6fa4064678f66682723741898cfb2641","ref":"refs/heads/master","pushedAt":"2024-04-25T13:50:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(test/bakery): Mock http errors using SpinnakerHttpException in CompletedBakeTaskSpec (#4711)\n\nWith the introduction of the commit: e63a661e215461bd10ff0af90d416e9ca7fcfa6c , the expected behaviour of all BakeryService APIs is to throw Spinnaker*Exception when any http error has occurred.\n\n- CompletedBakeTask is invoking an API : lookupBake(region, bakeid) -https://github.com/spinnaker/orca/blob/d2f50242637207491ba9fdcc40eaf02c3255c447/orca-bakery/src/main/groovy/com/netflix/spinnaker/orca/bakery/tasks/CompletedBakeTask.groovy#L43. This API error response is mocked up with RetrofitError in the test : https://github.com/spinnaker/orca/blob/d2f50242637207491ba9fdcc40eaf02c3255c447/orca-bakery/src/test/groovy/com/netflix/spinnaker/orca/bakery/tasks/CompletedBakeTaskSpec.groovy#L84\n\n- This test case seems to be invalid/irrelevant because it has to throw SpinnakerHttpException here.\n\nThis commit aims at correcting this unexpected behaviour.\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"fix(test/bakery): Mock http errors using SpinnakerHttpException in Co…"}},{"before":"3bc345befafe1d4b321c2831ea6886f99979cea6","after":"d2f50242637207491ba9fdcc40eaf02c3255c447","ref":"refs/heads/master","pushedAt":"2024-04-24T18:43:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(clouddriver): Throw SpinnakerHttpException when Http status is 403 in DetermineSourceServerGroupTask (#4710)\n\n* test(clouddriver): Demonstrate bug in DetermineSourceServerGroupTask\n\nThis task/class is suppose to throw a SpinnakerHttpException when a HTTP forbidden 403 error occurs, but instead it returns TaskResult in which the execution status and exception message is wrapped.\n\nThis task/class actually makes a couple of oortService API calls: 1 - oortService.getTargetServerGroup() - API to fetch the server group based on the target. 2 - oortService.getServerGroupsFromClusterTyped() - API to fetch server group based on server group name.\n\nFrom the commit: 84a7106c512ceada65d7799f527a956262d964d5 , OortService uses SpinnakerRetrofitErrorHandler so, the expectation is to throw SpinnakerHttpException.\n\n* fix(clouddriver): Throw SpinnakerHttpException when Http status is 403 in DetermineSourceServerGroupTask\n\nThis task earlier returns TaskResult with RUNNING status and exception message in context when Forbidden error 403 has occurred. With the new changes/fix it now throws SpinnakerHttpException in this scenario making it in compliance with the commit: 84a7106c512ceada65d7799f527a956262d964d5\n\nHere is the stack trace that would demonstrate the bug and the fix -\n\nBefore Fix:\n\nTaskResult(status=RUNNING, context={lastException=Status: 403, URL: http://localhost:39831/applications/testCluster/clusters/test/testCluster/aws/us-east-1/serverGroups/target/ancestor_asg_dynamic, Message: Forbidden\ncom.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException: Status: 403, URL: http://localhost:39831/applications/testCluster/clusters/test/testCluster/aws/us-east-1/serverGroups/target/ancestor_asg_dynamic, Message: Forbidden\n\tat com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerRetrofitErrorHandler.handleError(SpinnakerRetrofitErrorHandler.java:55)\n\tat retrofit.RestAdapter$RestHandler.invoke(RestAdapter.java:242)\n\tat jdk.proxy3/jdk.proxy3.$Proxy21.getTargetServerGroup(Unknown Source)\n\tat com.netflix.spinnaker.orca.clouddriver.OortService$getTargetServerGroup.call(Unknown Source)\n\tat com.netflix.spinnaker.orca.clouddriver.pipeline.servergroup.support.TargetServerGroupResolver$_resolveByTarget_closure2.doCall(TargetServerGroupResolver.groovy:76)\n\tat com.netflix.spinnaker.orca.clouddriver.pipeline.servergroup.support.TargetServerGroupResolver$_resolveByTarget_closure2.doCall(TargetServerGroupResolver.groovy)\n, attempt=2, consecutiveNotFound=0}, outputs={})\n\nAfter Fix:\n\n2024-04-24 16:48:25.900 ERROR   --- [    Test worker] .n.s.o.c.p.s.s.TargetServerGroupResolver : [] Unable to locate ancestor_asg_dynamic in test/us-east-1/testCluster\ncom.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException: Status: 403, URL: http://localhost:32773/applications/testCluster/clusters/test/testCluster/aws/us-east-1/serverGroups/target/ancestor_asg_dynamic, Message: Forbidden\n\tat com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerRetrofitErrorHandler.handleError(SpinnakerRetrofitErrorHandler.java:55)\n\tat retrofit.RestAdapter$RestHandler.invoke(RestAdapter.java:242)\n\tat jdk.proxy3/jdk.proxy3.$Proxy21.getTargetServerGroup(Unknown Source)\n\tat com.netflix.spinnaker.orca.clouddriver.OortService$getTargetServerGroup.call(Unknown Source)\n\tat com.netflix.spinnaker.orca.clouddriver.pipeline.servergroup.support.TargetServerGroupResolver$_resolveByTarget_closure2.doCall(TargetServerGroupResolver.groovy:76)\n\tat com.netflix.spinnaker.orca.clouddriver.pipeline.servergroup.support.TargetServerGroupResolver$_resolveByTarget_closure2.doCall(TargetServerGroupResolver.groovy)\n\n---------\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"fix(clouddriver): Throw SpinnakerHttpException when Http status is 40…"}},{"before":"ae3ef6c5d8542c3e94d2a401f9ca352e298ba5ac","after":"3bc345befafe1d4b321c2831ea6886f99979cea6","ref":"refs/heads/master","pushedAt":"2024-04-19T15:05:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(test/keel): Javadoc referring to missing method in ImportDeliveryConfigTaskTest (#4709)\n\nThis fix removes the javadoc link to the missing method: handleRetryableFailures(RetrofitError, ImportDeliveryConfigContext), which was cleaned up as part of the commit : 32e6571ad0578b9745a30fde75a85e8ac0d2b6b1.\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"fix(test/keel): Javadoc referring to missing method in ImportDelivery…"}},{"before":"83aa47f31f880192ee6ed69c65f262df2e62263a","after":"ae3ef6c5d8542c3e94d2a401f9ca352e298ba5ac","ref":"refs/heads/master","pushedAt":"2024-04-18T16:22:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(clouddriver): Handle the Retrofit conversionError in ClusterSizePreconditionTask (#4708)\n\n* fix(clouddriver): Handle the Retrofit conversionError in ClusterSizePreconditionTask\n\nThe oortService already uses SpinnakerRetrofitErrorHandler as part of the commit: 84a7106c512ceada65d7799f527a956262d964d5, so constructing the conversionError with RetrofitError would result in unexpected behaviour.\n\nWrapping up the conversion error into SpinnakerConversionError will fix this bug.\n\n* test(clouddriver): Test to verify conversion exception in ClusterSizePreconditionTask\n\nThe expectation is that the oortService APIs must throw only Spinnaker*Exceptions as it is already using SpinnakerRetrofitErrorHandler.\n\nThis test is to ensure that any future modifications on this fix must not result in unexpected behaviour.\n\n---------\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>","shortMessageHtmlLink":"fix(clouddriver): Handle the Retrofit conversionError in ClusterSizeP…"}},{"before":"90a383264fd3fdba7f6a0f487366cee9e744bc73","after":"83aa47f31f880192ee6ed69c65f262df2e62263a","ref":"refs/heads/master","pushedAt":"2024-04-17T17:21:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feat(front50): set front50.useTriggeredByEndpoint to true by default (#4707)\n\nso orca only queries for the pipelines it needs from front50 instead of all of them.\n\nhttps://github.com/spinnaker/orca/pull/4448 introduced this feature on Apr 20, 2023, first\nreleased in version 1.31.0 of Spinnaker.  Enough time has passed to enable this by\ndefault.","shortMessageHtmlLink":"feat(front50): set front50.useTriggeredByEndpoint to true by default (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2248453375\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4707\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4707/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4707\">#…</a>"}},{"before":"8ba984658509a84f63551113380b941edfca4b8d","after":"7799f041edd8aa35289ab0cd85e53bdade0a0837","ref":"refs/heads/release-1.33.x","pushedAt":"2024-04-17T00:53:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump fiatVersion (#4706)\n\nCo-authored-by: root <root@06c17b836b61>","shortMessageHtmlLink":"chore(dependencies): Autobump fiatVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2247090274\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4706\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4706/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4706\">#4706</a>)"}},{"before":"f3e30b31c76b3b36eff57153e72b9d9f1a91647d","after":"8ba984658509a84f63551113380b941edfca4b8d","ref":"refs/heads/release-1.33.x","pushedAt":"2024-04-16T23:59:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump korkVersion (#4705)\n\nCo-authored-by: root <root@075a7bb17710>","shortMessageHtmlLink":"chore(dependencies): Autobump korkVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2247044740\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4705\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4705/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4705\">#4705</a>)"}},{"before":null,"after":"90a383264fd3fdba7f6a0f487366cee9e744bc73","ref":"refs/heads/release-1.34.x","pushedAt":"2024-04-16T23:29:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbyron-sf","name":"David Byron","path":"/dbyron-sf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82477955?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump fiatVersion (#4704)\n\nCo-authored-by: root <root@28ff04fd44ba>","shortMessageHtmlLink":"chore(dependencies): Autobump fiatVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2246971074\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4704\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4704/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4704\">#4704</a>)"}},{"before":"fff90a45d112320781acd70197864ae8c3b8706b","after":"90a383264fd3fdba7f6a0f487366cee9e744bc73","ref":"refs/heads/master","pushedAt":"2024-04-16T22:34:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(dependencies): Autobump fiatVersion (#4704)\n\nCo-authored-by: root <root@28ff04fd44ba>","shortMessageHtmlLink":"chore(dependencies): Autobump fiatVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2246971074\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4704\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4704/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4704\">#4704</a>)"}},{"before":"38b447f9f10e17977deb8d9a43cf7289e0c84f4f","after":"fff90a45d112320781acd70197864ae8c3b8706b","ref":"refs/heads/master","pushedAt":"2024-04-16T21:38:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feat(sql): log the size of executions when they complete (#4660)\n\nto make changes in size over time more observable.  This makes it easier to see the impact\nof features like the artifact store.\n\nNot setting the size in RedisExecutionRepository because the extra\nobjectMapper.writeValueAsString is potentially expensive and I'm not sure how many folks\nare using redis for this.\n\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>","shortMessageHtmlLink":"feat(sql): log the size of executions when they complete (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2152958749\" data-permission-text=\"Title is private\" data-url=\"https://github.com/spinnaker/orca/issues/4660\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/spinnaker/orca/pull/4660/hovercard\" href=\"https://github.com/spinnaker/orca/pull/4660\">#4660</a>)"}},{"before":"fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd","after":"38b447f9f10e17977deb8d9a43cf7289e0c84f4f","ref":"refs/heads/master","pushedAt":"2024-04-16T13:59:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"refactor(front50): use SpinnakerRetrofitErrorHandler with Front50Service (#4623)\n\n* refactor(front50): use SpinnakerRetrofitErrorHandler with Front50Service\n\nThis PR lays the foundational work for upgrading the retrofit version to 2.x, specifically focusing on refactoring the exception handling for Front50Service.\n\nThere are no behaviour changes detected with these code changes and hence no additional tests added to demonstrate the functionalities.\nFew existing tests are modified to align it with the new changes.\n\n* refactor(applications): Cleanup RetrofitError in DeleteApplicationTask\n\nThere are 3 APIs invoked inside the try block:\n1. Keel Service API - keelService.deleteDeliveryConfig(): With the addition of the commit - c41792295d4b2bba289ab131699cc7b061ec627e, the keelService uses SpinnakerRetrofitErrorHandler.\n2. Front50 Service APIs - front50Service.get() and front50Service.delete(): With the addition of the commit - a44b5bbc84938eb58731ea9c813d702750026fb6, the front50 service uses SpinnakerRetrofitErrorHandler.\n\nand hence with the above mentioned commits, the catch block with RetrofitError becomes irrelevant.\n\n* refactor(igor): Cleanup RetrofitError in GetCommitsTask\n\nThere are total of 5 API calls happening inside the try block:\n1. Igor Service API - scmService.compareCommits(): With the addition of the commit - d430b75efeced7eb1f8d64eff6f0a160210eb2e6, the igorService uses SpinnakerRetrofitErrorHandler.\n2. Clouddriver APIs (OortService) - cloudDriverService.getByAmiId() - This is invoked twice in the block, and oortService.getServerGroupFromCluster(): With the addition of the commit - 84a7106c512ceada65d7799f527a956262d964d5, the oortService uses SpinnakerRetrofitErrorHandler.\n3. Front50 API - front50Service.get(): With the addition of the commit - a44b5bbc84938eb58731ea9c813d702750026fb6, the front50Service uses SpinnakerRetrofitErrorHandler.\n\nand hence with the above mentioned commits, the catch block with RetrofitError becomes irrelevant.\n\n* refactor(test/clouddriver): Cleanup impractical tests in TrafficGuardSpec\n\nThe API call 'front50Service.get(application)' mocked/stubbed to return null value is not realistic, because if the application is not available , then this API would throw a 404 HTTP error and thats already handled in the same class: https://github.com/spinnaker/orca/blob/7e923cc05af0f66b952245722aa69c667f685c5c/orca-clouddriver/src/test/groovy/com/netflix/spinnaker/orca/clouddriver/utils/TrafficGuardSpec.groovy#L464.\n\nand hence this test is cleaned up.\n\n* refactor(test/applications): Cleanup impractical tests in UpsertApplicationTaskSpec\n\nThe API call 'front50Service.get(application)' mocked/stubbed to return null value is not realistic, because if the application is not present, then this API would throw a 404 HTTP error.\n\nand hence this test is cleaned up.\n\n* refactor(test): adjust UpsertApplicationTaskSpec tests to use realistic behavior of Front50Service.get\n\nwhen an application isn't found.  It doesn't return null in this case, it throws an exception.\n\nRestore previously removed \"should create an application in global registries\" test since\nit was providing useful coverage.\n\n---------\n\nCo-authored-by: Pranav-b-7 <pranav.bhaskaran@opsmx.com>\nCo-authored-by: David Byron <dbyron@salesforce.com>","shortMessageHtmlLink":"refactor(front50): use SpinnakerRetrofitErrorHandler with Front50Serv…"}},{"before":"8c82579de53596f3f9d6c15b501d15b24c68a0b8","after":null,"ref":"refs/heads/mergify/bp/release-1.33.x/pr-4697","pushedAt":"2024-04-15T22:44:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"895cdce7b02a0e8b38d4c2db914b48b4ada7dab5","after":"f3e30b31c76b3b36eff57153e72b9d9f1a91647d","ref":"refs/heads/release-1.33.x","pushedAt":"2024-04-15T22:44:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (backport #4697) (#4702)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (#4697)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql module\n\n* test(sql): demonstrate behavior of retrievePipelinesForApplication\n\nwhich also verifies the behavior of selectExections when cursor is null\n\n---------\n\nCo-authored-by: David Byron <dbyron@salesforce.com>\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>\n(cherry picked from commit fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd)\n\n# Conflicts:\n#\torca-sql/src/test/kotlin/com/netflix/spinnaker/orca/sql/pipeline/persistence/SqlExecutionRepositoryTest.kt\n\n* fix(sql/test): remove compression-related tests\n\nsince compression was added after cutting the release-1.33.x branch\n\n---------\n\nCo-authored-by: juangod-wise <juan.godfrid@transferwise.com>\nCo-authored-by: David Byron <dbyron@salesforce.com>","shortMessageHtmlLink":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql …"}},{"before":"1f2359e279b334756f9066ede15502cbad8b2b2f","after":"8c82579de53596f3f9d6c15b501d15b24c68a0b8","ref":"refs/heads/mergify/bp/release-1.33.x/pr-4697","pushedAt":"2024-04-15T22:31:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dbyron-sf","name":"David Byron","path":"/dbyron-sf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82477955?s=80&v=4"},"commit":{"message":"fix(sql/test): remove compression-related tests\n\nsince compression was added after cutting the release-1.33.x branch","shortMessageHtmlLink":"fix(sql/test): remove compression-related tests"}},{"before":"dc7c882fa0569862c9f170905ce4c3432b6f6655","after":null,"ref":"refs/heads/mergify/bp/release-1.32.x/pr-4697","pushedAt":"2024-04-15T22:29:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"9d37de51d25f1b701adb44163d5bb613dbea32b4","after":"c64ed7f42d6235a29ae5d850aec0d752da26094e","ref":"refs/heads/release-1.32.x","pushedAt":"2024-04-15T22:28:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (backport #4697) (#4701)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (#4697)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql module\n\n* test(sql): demonstrate behavior of retrievePipelinesForApplication\n\nwhich also verifies the behavior of selectExections when cursor is null\n\n---------\n\nCo-authored-by: David Byron <dbyron@salesforce.com>\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>\n(cherry picked from commit fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd)\n\n# Conflicts:\n#\torca-sql/src/test/kotlin/com/netflix/spinnaker/orca/sql/pipeline/persistence/SqlExecutionRepositoryTest.kt\n\n* fix(sql/test): remove compression-related tests\n\nsince compression was added after cutting the release-1.32.x branch\n\n---------\n\nCo-authored-by: juangod-wise <juan.godfrid@transferwise.com>\nCo-authored-by: David Byron <dbyron@salesforce.com>","shortMessageHtmlLink":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql …"}},{"before":"92537d1a7828db16c3a3f280de25013755e2172f","after":"dc7c882fa0569862c9f170905ce4c3432b6f6655","ref":"refs/heads/mergify/bp/release-1.32.x/pr-4697","pushedAt":"2024-04-15T20:29:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dbyron-sf","name":"David Byron","path":"/dbyron-sf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82477955?s=80&v=4"},"commit":{"message":"fix(sql/test): remove compression-related tests\n\nsince compression was added after cutting the release-1.32.x branch","shortMessageHtmlLink":"fix(sql/test): remove compression-related tests"}},{"before":null,"after":"1f2359e279b334756f9066ede15502cbad8b2b2f","ref":"refs/heads/mergify/bp/release-1.33.x/pr-4697","pushedAt":"2024-04-15T20:16:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (#4697)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql module\n\n* test(sql): demonstrate behavior of retrievePipelinesForApplication\n\nwhich also verifies the behavior of selectExections when cursor is null\n\n---------\n\nCo-authored-by: David Byron <dbyron@salesforce.com>\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>\n(cherry picked from commit fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd)\n\n# Conflicts:\n#\torca-sql/src/test/kotlin/com/netflix/spinnaker/orca/sql/pipeline/persistence/SqlExecutionRepositoryTest.kt","shortMessageHtmlLink":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … ("}},{"before":null,"after":"92537d1a7828db16c3a3f280de25013755e2172f","ref":"refs/heads/mergify/bp/release-1.32.x/pr-4697","pushedAt":"2024-04-15T20:16:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (#4697)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql module\n\n* test(sql): demonstrate behavior of retrievePipelinesForApplication\n\nwhich also verifies the behavior of selectExections when cursor is null\n\n---------\n\nCo-authored-by: David Byron <dbyron@salesforce.com>\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>\n(cherry picked from commit fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd)\n\n# Conflicts:\n#\torca-sql/src/test/kotlin/com/netflix/spinnaker/orca/sql/pipeline/persistence/SqlExecutionRepositoryTest.kt","shortMessageHtmlLink":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … ("}},{"before":"a27e88a0a30156b5b000c5eb763b4a796be7763a","after":"fc072b3a96d0fd1d8691cb01cdc1744c3fa793dd","ref":"refs/heads/master","pushedAt":"2024-04-15T20:08:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … (#4697)\n\n* fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql module\n\n* test(sql): demonstrate behavior of retrievePipelinesForApplication\n\nwhich also verifies the behavior of selectExections when cursor is null\n\n---------\n\nCo-authored-by: David Byron <dbyron@salesforce.com>\nCo-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>","shortMessageHtmlLink":"fix(SqlExecutionRepository): fixed bug in sql repository in orca-sql … ("}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPwSFvQA","startCursor":null,"endCursor":null}},"title":"Activity · spinnaker/orca"}