Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getChildren() is used for nodes, should only be used for data items #118

Open
wonder-mice opened this issue Sep 29, 2018 · 1 comment
Open

getChildren() is used for nodes, should only be used for data items #118

wonder-mice opened this issue Sep 29, 2018 · 1 comment

Comments

@wonder-mice
Copy link

Currently getChildren() is used inconsistently. For d3 nodes must use node.children directly - faster and more correct. getChildren() must only be used for hierarchy() calls (maybe there are some other use cases, but mostly it).
@wonder-mice
Copy link
Author

I'm working on it.

@spiermar spiermar added the enhancement New feature or request label Sep 29, 2018
@spiermar spiermar added this to the 3.0 milestone Oct 23, 2018
@spiermar spiermar self-assigned this Oct 23, 2018
@spiermar spiermar removed this from the 3.0 milestone Oct 12, 2021
@spiermar spiermar removed the enhancement New feature or request label Oct 12, 2021
@spiermar spiermar removed their assignment Oct 12, 2021
@gitworkflows gitworkflows mentioned this issue Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wonder-mice @spiermar